Jack-mobile-responsiveness #220
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -21,8 +21,8 @@ export function OpenShortsTable({ | |||||
|
|
||||||
| return ( | ||||||
| <SortableGridTable | ||||||
| headingRowClassName="grid-cols-4 text-neutral-content mx-2" | ||||||
| bodyRowClassName="grid-cols-4 text-base-content items-center text-sm md:text-h6 even:bg-secondary/5 h-16 mx-2" | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| // Blank col added for actions | ||||||
| cols={["Position", "Balance", "Value", "Matures on", ""]} | ||||||
| rows={openShortRows} | ||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,25 +14,34 @@ export function PositionTabs({ | |
| <div className="daisy-tabs"> | ||
| <button | ||
| onClick={() => setActivePositionTab("Longs")} | ||
| className={classNames( | ||
| "daisy-tab-lifted daisy-tab daisy-tab-sm border-b-base-100 md:daisy-tab-lg", | ||
| { | ||
| "daisy-tab-active glass": activePositionTab === "Longs", | ||
| }, | ||
| )} | ||
| > | ||
| Longs | ||
| </button> | ||
| <button | ||
| onClick={() => setActivePositionTab("Shorts")} | ||
| className={classNames( | ||
| "daisy-tab-lifted daisy-tab daisy-tab-sm border-b-base-100 md:daisy-tab-lg", | ||
| { | ||
| "daisy-tab-active glass": activePositionTab === "Shorts", | ||
| }, | ||
| )} | ||
| > | ||
| Shorts | ||
| </button> | ||
| <button | ||
| onClick={() => setActivePositionTab("LP")} | ||
| className={classNames( | ||
| "daisy-tab-lifted daisy-tab daisy-tab-sm border-b-base-100 md:daisy-tab-lg", | ||
| { | ||
| "daisy-tab-active glass": activePositionTab === "LP", | ||
| }, | ||
| )} | ||
| > | ||
| LP | ||
| </button> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,19 +52,16 @@ export function PositionsSection({ | |
|
|
||
| return ( | ||
| <div> | ||
| <div className="mb-4 flex w-full items-end justify-between border-b border-neutral-content/30"> | ||
| <PositionTabs | ||
| setActivePositionTab={handleChangeTab} | ||
| activePositionTab={activePositionTab} | ||
| /> | ||
|
|
||
| <div className="daisy-tabs-boxed mb-1"> | ||
| <button | ||
| onClick={() => handleChangeOpenOrClosedTab("Open")} | ||
| className={classNames("daisy-tab text-sm", { | ||
| "daisy-tab-active !bg-base-300 !text-white": | ||
| activeOpenOrClosedTab === "Open", | ||
| })} | ||
|
|
@@ -73,7 +70,7 @@ export function PositionsSection({ | |
| </button> | ||
| <button | ||
| onClick={() => handleChangeOpenOrClosedTab("Closed")} | ||
| className={classNames("daisy-tab text-sm", { | ||
| "daisy-tab-active !bg-base-300 !text-white": | ||
| activeOpenOrClosedTab === "Closed", | ||
| })} | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,13 +23,15 @@ export function TradeBody({ hyperdrive }: PositionsTableProps): ReactElement { | |
| <div className="flex max-w-5xl flex-col gap-16 "> | ||
| {/* Name w/ market select */} | ||
| <div className="flex w-full flex-col gap-6"> | ||
| <div className="flex flex-wrap items-start justify-center md:justify-between"> | ||
| <div className="flex shrink-0 flex-col"> | ||
| <div className="flex flex-1 justify-between"> | ||
| <YieldSourceLabel yieldSource={yieldSource} /> | ||
| <MarketSelect markets={[hyperdrive]} /> | ||
| </div> | ||
| <p className="my-2 text-h3 font-semibold md:my-0"> | ||
| {hyperdrive.name} | ||
| </p> | ||
| </div> | ||
| <YourBalanceWell token={hyperdrive.baseToken} /> | ||
| </div> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
px-4here will shrink the width on the container at full width too. Rather than horiz spacing on the children, we should probably put padding on on the page container.