Jack-mobile-responsiveness #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ryangoree
approved these changes
Jul 12, 2023
| @@ -3,7 +3,7 @@ import { Disclosure } from "src/ui/base/components/Disclosure/Disclosure"; | |||
|
|
|||
| export function FAQ(): ReactElement { | |||
| return ( | |||
| <div className="flex flex-col gap-6 pb-12"> | |||
| <div className="flex flex-col gap-6 px-4 pb-12"> | |||
There was a problem hiding this comment.
The px-4 here will shrink the width on the container at full width too. Rather than horiz spacing on the children, we should probably put padding on on the page container.
| @@ -21,7 +21,7 @@ export function ClosedLongsTable({ | |||
| return ( | |||
| <SortableGridTable | |||
| headingRowClassName="grid-cols-5 text-neutral-content" | |||
| bodyRowClassName="grid-cols-5 text-base-content items-center text-h6 even:bg-secondary/5 h-16" | |||
| bodyRowClassName="grid-cols-4 text-base-content items-center text-sm md:text-h6 even:bg-secondary/5 h-16 mx-2" | |||
There was a problem hiding this comment.
Same comment here about horiz spacing. We can remove the mx-2 class.
| headingRowClassName="grid-cols-4 text-neutral-content" | ||
| bodyRowClassName="grid-cols-4 text-base-content items-center text-h6 even:bg-secondary/5 h-16" | ||
| headingRowClassName="grid-cols-4 text-start text-neutral-content mx-2" | ||
| bodyRowClassName="grid-cols-4 text-base-content items-center text-sm md:text-h6 even:bg-secondary/5 h-16 mx-2" |
There was a problem hiding this comment.
Suggested change
| bodyRowClassName="grid-cols-4 text-base-content items-center text-sm md:text-h6 even:bg-secondary/5 h-16 mx-2" | |
| bodyRowClassName="grid-cols-4 text-base-content items-center text-sm md:text-h6 even:bg-secondary/5 h-16" |
| headingRowClassName="grid-cols-4 text-neutral-content" | ||
| bodyRowClassName="grid-cols-4 text-base-content items-center text-h6 even:bg-accent/5 h-16" | ||
| headingRowClassName="grid-cols-4 text-neutral-content mx-2" | ||
| bodyRowClassName="grid-cols-4 text-base-content items-center text-sm md:text-h6 even:bg-secondary/5 h-16 mx-2" |
There was a problem hiding this comment.
Suggested change
| bodyRowClassName="grid-cols-4 text-base-content items-center text-sm md:text-h6 even:bg-secondary/5 h-16 mx-2" | |
| bodyRowClassName="grid-cols-4 text-base-content items-center text-sm md:text-h6 even:bg-secondary/5 h-16" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After: