Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop due to missing fiat values #1692

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

DannyDelott
Copy link
Contributor

Sorting requires TVL, which was throwing an error in getPresentValue and causing an infinite render loop. We need to fallback to TVL in terms of base in these cases.

We're waiting to see if defillama has delisted these tokens,, or if the fiat price endpoint will be fixed soon. If not, we'll need to find a new price sensor for nARS, Wrapped XDAI, and USDA.

USDA: https://coins.llama.fi/prices/current/ethereum:0x0000206329b97DB379d5E1Bf586BbDB969C63274
Wrapped XDai: https://coins.llama.fi/prices/current/gnosis:0xe91D153E0b41518A2Ce8Dd3D7944Fa863463a97d
nARS: https://coins.llama.fi/prices/current/base:0x5e40f26E89213660514c51Fb61b2d357DBf63C85

Copy link

changeset-bot bot commented Dec 17, 2024

⚠️ No Changeset found

Latest commit: e0adc0c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-mainnet-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 7:06pm
hyperdrive-sepolia-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 7:06pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hyperdrive-js ⬜️ Ignored (Inspect) Dec 17, 2024 7:06pm
hyperdrive-mainnet-production ⬜️ Ignored (Inspect) Dec 17, 2024 7:06pm
hyperdrive-sepolia-production ⬜️ Ignored (Inspect) Dec 17, 2024 7:06pm
testnet-v1 ⬜️ Ignored (Inspect) Dec 17, 2024 7:06pm
testnet-v1.0.6 ⬜️ Ignored (Inspect) Dec 17, 2024 7:06pm
trading-competition ⬜️ Ignored (Inspect) Dec 17, 2024 7:06pm

@DannyDelott DannyDelott merged commit a6898ae into main Dec 17, 2024
15 checks passed
@DannyDelott DannyDelott deleted the danny-fix-sorting branch December 17, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants