Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable sorting #1691

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Temporarily disable sorting #1691

merged 1 commit into from
Dec 17, 2024

Conversation

DannyDelott
Copy link
Contributor

Hotfix to disable sorting while we troubleshoot an infinite loop

@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-mainnet-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 5:46pm
hyperdrive-sepolia-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 5:46pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hyperdrive-js ⬜️ Ignored (Inspect) Dec 17, 2024 5:46pm
hyperdrive-mainnet-production ⬜️ Ignored (Inspect) Dec 17, 2024 5:46pm
hyperdrive-sepolia-production ⬜️ Ignored (Inspect) Dec 17, 2024 5:46pm
testnet-v1 ⬜️ Ignored (Inspect) Dec 17, 2024 5:46pm
testnet-v1.0.6 ⬜️ Ignored (Inspect) Dec 17, 2024 5:46pm
trading-competition ⬜️ Ignored (Inspect) Dec 17, 2024 5:46pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2024

⚠️ No Changeset found

Latest commit: 2329e20

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DannyDelott DannyDelott merged commit 799271f into main Dec 17, 2024
9 checks passed
@DannyDelott DannyDelott deleted the danny-jack-hotfix-remove-sorting branch December 17, 2024 17:46
DannyDelott added a commit that referenced this pull request Dec 17, 2024
@DannyDelott
Revert "Temporarily disable sorting (#1691)"
5e69a5f 
This reverts commit 799271f.
DannyDelott added a commit that referenced this pull request Dec 17, 2024
@DannyDelott
Fix infinite loop due to missing fiat values (#1692)
a6898ae 
* Revert "Temporarily disable sorting (#1691)"

This reverts commit 799271f.

* Fallback to presentValue in base when fiat value doesnt exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryangoree ryangoree ryangoree approved these changes

@jackburrus jackburrus jackburrus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DannyDelott @ryangoree @jackburrus