Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore sorting feature on All Pools page #1679

Merged
merged 10 commits into from
Dec 13, 2024

Conversation

DannyDelott
Copy link
Contributor

Closes #1564

Brings back sorting.

  • Adds makeQueryKey2 to standandarize query key lookups
  • Refactors PoolsList to consume a new usePoolsList hook that returns sorted pool rows
Hyperdrive---DeFi-Yield-your-way.7.webm

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-mainnet-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 6:30am
hyperdrive-sepolia-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 6:30am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hyperdrive-js ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 6:30am
hyperdrive-mainnet-production ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 6:30am
hyperdrive-sepolia-production ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 6:30am
testnet-v1 ⬜️ Ignored (Inspect) Dec 13, 2024 6:30am
testnet-v1.0.6 ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 6:30am
trading-competition ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 6:30am

Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: 37ca807

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR


const PINNED_POOLS = [
// Pin the 182d Savings GYD pool to the top of the list
// Remove this pinning on Wednesday, December 4, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still relevant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to leave it pinned for now, since it has decent liquidity, but we should talk to folks and see if it makes sense to unpin.

* preventing the UI from freezing due to slow Alchemy responses.
*/
export function usePoolsListIsFetching(): boolean {
const totalRequests = useIsFetching();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this hook? We could just do this in the component.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, this was unreferenced code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Sorting back to the pools list page
2 participants