Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sorting back to the pools list page #1564

Closed
DannyDelott opened this issue Oct 14, 2024 · 1 comment · Fixed by #1679
Closed

Add Sorting back to the pools list page #1564

DannyDelott opened this issue Oct 14, 2024 · 1 comment · Fixed by #1679
Assignees

Comments

@DannyDelott
Copy link
Contributor

Followup to when Filtering was added, we should include sorting as well.

@DannyDelott DannyDelott self-assigned this Oct 14, 2024
@DannyDelott
Copy link
Contributor Author

We removed sorting for now due to performance concerns. Sorting requires loading all the pool data, which can take up to 20 seconds or more if Alchemy experiences slower response times.

We've made improvements to load as much as we can in parallel, however the expensive calls cannot be optimized with multicall, since eth_getBlock and eth_getLogs are not a part of the multicall spec.

@DannyDelott DannyDelott changed the title Add Sorting to route search params Add Sorting back to the pools list page Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant