Fixes 104 81 152 #163
Fixes 104 81 152 #163
Conversation
Tests were put in a separate file. They are now relocated to the file with the other delphin.mrs.compare tests.
Functionality fixed in `delphin.mrs.eds.dump()`, `delphin.mrs.simplemrs.dump()`, `delphin.mrs.simpledmrs.dump()`, `delphin.mrs.mrx.dump()`, `delphin.mrs.dmrx.dump()`, `delphin.mrs.prolog.dump()` Fixes #152
CHANGELOG.md
Outdated
| * `delphin.mrs.components.stringpred()`; replaced with | ||
| `delphin.mrs.components.surface()` | ||
| * `delphin.mrs.components.grammarpred()`; replaced with | ||
| `delphin.mrs.components.abstract()` |
There was a problem hiding this comment.
The paths are wrong; they are missing the Pred class before the method names
delphin/mrs/dmrx.py
Outdated
| print(text, file=fh) | ||
| else: | ||
| with open(fh, 'w') as fh: | ||
| print(text, file=fh) |
There was a problem hiding this comment.
fh stands for "file handle", and if it doesn't have the write attribute it's not a file handle, so I would prefer that the incoming function parameter is renamed (e.g., destination or something), here and for the other serializers. E.g.,
else:
with open(destination, 'w') as fh:
print(text, file=fh)In general I like to avoid assigning values of different types (e.g., string or file object here) to the same variable name. Even though it's valid Python, it gets confusing.
delphin/mrs/dmrx.py
Outdated
| single=single, | ||
| properties=properties, | ||
| pretty_print=pretty_print, | ||
| **kwargs) |
There was a problem hiding this comment.
The indentation is odd here. if ms is on the same line as the function name, then the other parameters should line up with ms and not with the opening parenthesis. See PEP8.
text = dumps(ms,
single=single,
properties=properties,
pretty_print=pretty_print,
**kwargs)Or they can all be indented one level after the first line:
text = dumps(
ms,
single=single,
properties=properties,
pretty_print=pretty_print,
**kwargs)CHANGELOG had incorrect method paths for `delphin.mrs.components.Pred` update Variables in mrs dump() functions renamed from fh to destination for clarity; indentation fixed
tdl.parse()now accepts file or filenameFixes #104
tdl.parse_* functions are now private
Fixes #81
MRS dump() functions now allow files or filenames
Fixes #152