Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*MRS serializers inconsistently (dis)allow filenames in dump() function #152

Closed
goodmami opened this issue Jun 20, 2018 · 0 comments
Closed

*MRS serializers inconsistently (dis)allow filenames in dump() function #152

goodmami opened this issue Jun 20, 2018 · 0 comments
Assignees
@mcmillanmajora
Labels
good first issue
Milestone
v0.8.0

Comments

@goodmami
Copy link
Member

Some serializers, such as penman.dump(), allow a filename as the first parameter instead of a file, but others (e.g., simplemrs.dump(), mrx.dump()) only allow file objects (despite docstring claims).

These should be made consistent.
@goodmami goodmami added this to the v0.8.0 milestone Aug 6, 2018
mcmillanmajora added a commit that referenced this issue Aug 8, 2018
@mcmillanmajora
MRS dump() functions now allow files or filenames
a504e28 
Functionality fixed in  `delphin.mrs.eds.dump()`,
`delphin.mrs.simplemrs.dump()`, `delphin.mrs.simpledmrs.dump()`,
`delphin.mrs.mrx.dump()`, `delphin.mrs.dmrx.dump()`,
`delphin.mrs.prolog.dump()`
Fixes #152
@mcmillanmajora mcmillanmajora mentioned this issue Aug 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcmillanmajora mcmillanmajora

Labels
good first issue
Projects
None yet
Milestone
v0.8.0
Development

No branches or pull requests
2 participants
@goodmami @mcmillanmajora