Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix 1534 nvme block resize #50

Merged
merged 7 commits into from
Oct 25, 2024
Merged

Bugfix 1534 nvme block resize #50

merged 7 commits into from
Oct 25, 2024

Conversation

AkshaySainiDell
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell commented Oct 25, 2024 •
edited
Loading

Description

Add support to :

  1. Find a nvme block device based on wwn
  2. Find controller of a nvme block device.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1534

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • UT
    image
  • Tested with PowerMax
    image
  • Tested with PowerStore
    image

@AkshaySainiDell AkshaySainiDell marked this pull request as ready for review October 25, 2024 12:26
@AkshaySainiDell AkshaySainiDell merged commit bbd60d6 into main Oct 25, 2024
4 checks passed
@AkshaySainiDell AkshaySainiDell deleted the bugfix-1534-nvme-block-resize branch October 25, 2024 12:45
@rishabhatdell rishabhatdell mentioned this pull request Oct 29, 2024
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpjain2004 bpjain2004 bpjain2004 approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@rishabhatdell rishabhatdell rishabhatdell approved these changes

@kumarp20 kumarp20 Awaiting requested review from kumarp20 kumarp20 is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@xuluna xuluna Awaiting requested review from xuluna xuluna is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@KerryKovacevic KerryKovacevic Awaiting requested review from KerryKovacevic

@EvgenyUglov EvgenyUglov Awaiting requested review from EvgenyUglov EvgenyUglov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AkshaySainiDell @bpjain2004 @suryagupta4 @rishabhatdell