Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NVMe support for block device #49

Closed
wants to merge 8 commits into from
Closed

Add NVMe support for block device #49

wants to merge 8 commits into from

Conversation

AkshaySainiDell
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell commented Oct 23, 2024 •
edited by rishabhatdell
Loading

Description

Add support to find nvme block device based on wwn and rescan a nvme device.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1534

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • UT
    image
    image

  • Tested volume expansion with PowerStore
    image

@AkshaySainiDell AkshaySainiDell changed the title Nvme vol resize Add NVMe support for block device Oct 24, 2024
@rishabhatdell rishabhatdell marked this pull request as ready for review October 24, 2024 11:15
suryagupta4
suryagupta4 previously approved these changes Oct 24, 2024
View reviewed changes
adarsh-dell
adarsh-dell previously approved these changes Oct 24, 2024
View reviewed changes
harishp8889
harishp8889 previously approved these changes Oct 24, 2024
View reviewed changes
francis-nijay
francis-nijay previously approved these changes Oct 24, 2024
View reviewed changes
@rishabhatdell
Copy link
Contributor

added PR #50 instead of this

@suryagupta4 suryagupta4 deleted the nvme_vol_resize branch November 4, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harishp8889 harishp8889 harishp8889 left review comments

@francis-nijay francis-nijay francis-nijay left review comments

@suryagupta4 suryagupta4 suryagupta4 left review comments

@adarsh-dell adarsh-dell adarsh-dell left review comments

@kumarp20 kumarp20 Awaiting requested review from kumarp20 kumarp20 is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@xuluna xuluna Awaiting requested review from xuluna xuluna is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@KerryKovacevic KerryKovacevic Awaiting requested review from KerryKovacevic

@EvgenyUglov EvgenyUglov Awaiting requested review from EvgenyUglov EvgenyUglov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AkshaySainiDell @rishabhatdell @harishp8889 @francis-nijay @suryagupta4 @adarsh-dell