Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated replication extension package #166

Merged
merged 3 commits into from
Feb 10, 2023
Merged

Updated replication extension package #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4c3121
Updated replication extension package
santhoshatdell Feb 7, 2023
5f70792
Updated replicator sidecar version
santhoshatdell Feb 9, 2023
b03409a
Fixed issue reported by GoSec - Deferring unsafe method Close on type…
santhoshatdell Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ require (
github.com/cucumber/godog v0.10.0
github.com/dell/dell-csi-extensions/common v1.1.0
github.com/dell/dell-csi-extensions/podmon v1.1.1
github.com/dell/dell-csi-extensions/replication v1.2.1
github.com/dell/dell-csi-extensions/replication v1.2.2-0.20230112204455-8f3445ef5483
github.com/dell/dell-csi-extensions/volumeGroupSnapshot v1.2.1
github.com/dell/gocsi v1.6.0
github.com/dell/gofsutil v1.11.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ github.com/dell/dell-csi-extensions/common v1.1.0 h1:BFWoXdAennOs+fFiYqsGo02AU27
github.com/dell/dell-csi-extensions/common v1.1.0/go.mod h1:x68COjv2yqphSmGWZDPV9WcBENA9+e8v21aGFO5i3PQ=
github.com/dell/dell-csi-extensions/podmon v1.1.1 h1:AIFHmVscJInpADaJyXMuvpHZKAhLpQhD+7dFHjHKdjI=
github.com/dell/dell-csi-extensions/podmon v1.1.1/go.mod h1:J4VNEmXV6sz40QviNF1B+Ov+KNQmzFtJw0YNUpq6ncs=
github.com/dell/dell-csi-extensions/replication v1.2.1 h1:dx67k7BBN/aZKgPdOgO04PNFTciChnNwIx+Cnwlgq0s=
github.com/dell/dell-csi-extensions/replication v1.2.1/go.mod h1:FU2kzS8/29GlK9iCdS+E70cyeWun63eNP44aHwg7jW8=
github.com/dell/dell-csi-extensions/replication v1.2.2-0.20230112204455-8f3445ef5483 h1:sVMPxFaRBk80s+gwPAtzw1mtcjefDdvv1drkoyK1/kg=
github.com/dell/dell-csi-extensions/replication v1.2.2-0.20230112204455-8f3445ef5483/go.mod h1:FU2kzS8/29GlK9iCdS+E70cyeWun63eNP44aHwg7jW8=
github.com/dell/dell-csi-extensions/volumeGroupSnapshot v1.2.1 h1:EQAa1da2njL31ev6pJ6X4KTynKB4qpN6ZcuWYdZ58hI=
github.com/dell/dell-csi-extensions/volumeGroupSnapshot v1.2.1/go.mod h1:etLWwS1G2IqHDuArHqB0OWQvpdcztuBxopWrRE+mpk0=
github.com/dell/gocsi v1.6.0 h1:ZmoMi17v1jK0RE0OGEivu52/RqHbOhP5cqs9SHExqa0=
Expand Down
2 changes: 1 addition & 1 deletion helm/csi-isilon/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ controller:
# image: Image to use for dell-csi-replicator. This shouldn't be changed
# Allowed values: string
# Default value: None
image: dellemc/dell-csi-replicator:v1.3.0
image: dellemc/dell-csi-replicator:v1.4.0

# replicationContextPrefix: prefix to use for naming of resources created by replication feature
# Allowed values: string
Expand Down
6 changes: 5 additions & 1 deletion service/controllerNodeToArrayConnectivity.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,11 @@ func (s *service) queryArrayStatus(ctx context.Context, url string) (bool, error
log.Errorf("failed to call API %s due to %s ", url, err.Error())
return false, err
}
defer resp.Body.Close()
defer func() {
if err := resp.Body.Close(); err != nil {
log.Printf("Error closing HTTP response: %s", err.Error())
}
}()
bodyBytes, err := ioutil.ReadAll(resp.Body)
if err != nil {
log.Errorf("failed to read API response due to %s ", err.Error())
Expand Down