Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix type in FARMReader's save_to_remote #3952

Merged
merged 1 commit into from
Jan 26, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion haystack/nodes/reader/farm.py
Original file line number Diff line number Diff line change
Expand Up @@ -744,7 +744,7 @@ def save(self, directory: Path):
self.inferencer.processor.save(directory)

def save_to_remote(
self, repo_id: str, private: Optional[bool] = None, commit_message: str = "Add new model to Hugging Face."
self, repo_id: str, private: bool = False, commit_message: str = "Add new model to Hugging Face."
):
"""
Saves the Reader model to Hugging Face Model Hub with the given model_name. For this to work:
Expand Down