Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix type in FARMReader's save_to_remote #3952

Merged
merged 1 commit into from
Jan 26, 2023
Merged

fix: Fix type in FARMReader's save_to_remote #3952

merged 1 commit into from
Jan 26, 2023

Conversation

bogdankostic
Copy link
Contributor

@bogdankostic bogdankostic commented Jan 26, 2023 •
edited
Loading

Related Issues

  • n/a

Proposed Changes:

This PR changes the type of the private argument in FARMReader's save_to_remote method from Optional[bool] to bool and sets the default value to False.

How did you test it?

mypy

Notes for the reviewer

This issue came up due to many recent PRs failing the mypy check. huggingface_hub's create_repo method only allows bools as parameter for private, None is not allowed.

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@bogdankostic bogdankostic marked this pull request as ready for review January 26, 2023 10:21
@bogdankostic bogdankostic requested a review from a team as a code owner January 26, 2023 10:21
@bogdankostic bogdankostic requested review from mayankjobanputra and removed request for a team January 26, 2023 10:21
@bogdankostic bogdankostic merged commit addebcd into main Jan 26, 2023
@bogdankostic bogdankostic deleted the fix_type_save_to_remote branch January 26, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@mayankjobanputra mayankjobanputra Awaiting requested review from mayankjobanputra mayankjobanputra is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bogdankostic @silvanocerza