secp256k1: update func signatures. #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajohi
changed the title
|
@dnldd rebase required. |
dnldd
changed the title
davecgh
requested changes
Dec 21, 2017
funcs implicitly use the sec256k1 curve instead of passing it as a param.
|
@davecgh updated. |
|
Also, I should note that this doesn't completely resolve 923. It is the first step of it. Perhaps change the PR description to include work towards #923? |
davecgh
approved these changes
Dec 22, 2017
davecgh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies secp256k1 & schnorr related func signatures by removing the koblitz curve param. The secp256k1 curve is used implicitly instead.
This is work towards #923.