Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secp256k1 package needs cleanup #923

Closed
davecgh opened this issue Nov 21, 2017 · 2 comments
Closed

secp256k1 package needs cleanup #923

davecgh opened this issue Nov 21, 2017 · 2 comments

Comments

@davecgh
Copy link
Member

davecgh commented Nov 21, 2017

The secp256k1 package was ported over from the upstream btcsuite/btcec package which was initially intended to work with multiple curves, however, over time, due to optimizations, it really only works with the secp256k1 curve.

Decred made an attempt to separate this into a unique package named accordingly, however, it still has a lot of remnants that don't make sense when you're dealing with a specific curve such as accepting the curve as the first parameter.

In addition, due to the dcrec package changes, it's quite cumbersome to work with due to poor interface design. Cleaning all of this up will need to be a multistep process, however, this issue is just focusing on the first step of the process which is to make the secp256k1 a proper standalone package.

@davecgh
Copy link
Member Author

davecgh commented Dec 22, 2017

The first part of this is resolved by #934.

@tarun1475
Copy link

I am interested to work upon this issue. Kindly guide me what i need to do ?

@davecgh davecgh closed this as completed Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants