rm non-maintainted dist/ dir
#375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TooTallNate
reviewed
Dec 16, 2016
| @@ -142,8 +142,13 @@ debug('this is hex: %h', new Buffer('hello world')) | |||
| ``` | |||
|
|
|||
| ## Browser support | |||
| You can build a browser-ready script using [browserify](https://github.com/substack/node-browserify), | |||
There was a problem hiding this comment.
We should mention that it works out of the box with the popular browser bundlers. We mention browserify but at least webpack should be mentioned as well.
There was a problem hiding this comment.
I'm not familiar with webpack or anything besides browserify. Please add some info if you are able to. Otherwise, I still consider this PR an improvement as-is.
There was a problem hiding this comment.
Basically you can just require/import debug and module bundlers like webpack and browserify will compile it in at compile time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #372