Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating dist/ #372

Closed
freewil opened this issue Dec 15, 2016 · 4 comments · Fixed by #375
Closed

updating dist/ #372

freewil opened this issue Dec 15, 2016 · 4 comments · Fixed by #375

Comments

@freewil
Copy link
Contributor

freewil commented Dec 15, 2016

I noticed dist/ isn't being updated on each release.

I see at least 2 options:

  • Add a release script (could be extremely small 1-liner possibly) to update it, before each package.json bump and tag

  • Remove it from repo, have it built/published via travis
@TooTallNate
Copy link
Contributor

I'd prefer to just remove it personally. Who's using the dist file currently and for what?

@TooTallNate
Copy link
Contributor

And if it's for <script> tag usage, I'd recommend using the browserify CDN instead: https://wzrd.in/standalone/debug@latest

@freewil
Copy link
Contributor Author

freewil commented Dec 15, 2016

I noticed it was there, so I decided to use it for browser usage. But I agree, we should add/list alternative places to install from for browser to README and delete dist/.

I can open a PR to do this later today.

Cool - didn't know about browserify CDN.

@thebigredgeek
Copy link
Contributor

@freewil yah if you open a PR today I will gladly merge it. Thanks man

@freewil freewil mentioned this issue Dec 15, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rm non-maintainted dist/ dir freewil/debug
3 participants
@TooTallNate @freewil @thebigredgeek