Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing docs task from test, test-browserify and coverage build chain #808

Closed
wants to merge 5 commits into from

Conversation

paolodm
Copy link

@paolodm paolodm commented Dec 22, 2014

As mentioned in #799, an extra directory is being created upon grunt test. This directory, web/docs/public, is being created as part of the grunt-docco2 task.

It seems misplaced to me to have to build the docs during a test run. I don't think a user running grunt test expects the docs to be built during this phase of the build lifecycle. IMO, an appropriate place to build the docs is during the grunt build task.

@paolodm paolodm changed the title Removing docs task from test and test-browserify build chain Removing docs task from test, test-browserify and coverage build chain Dec 22, 2014
@gordonwoodhull
Copy link
Contributor

Thanks.

The problem with this is that if you don't do the build when you run the tests, you can't be certain that you are running the tests against all the latest changes (when doing development).

However, I think we can do something similar where the core artifacts are built but not the documentation.

@paolodm
Copy link
Author

paolodm commented Dec 22, 2014

Are the docs a prerequisite to running the tests? If they are, then I agree that you need to fire the docs task for the tests.

@gordonwoodhull
Copy link
Contributor

No, I'm just saying that the tests do depend on the file dc.js being built. I'm going to go with a simpler change with the same goal. Thanks for bringing this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants