Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra directory after running "grunt test" #799

Closed
wssbck opened this issue Dec 16, 2014 · 4 comments
Closed

Extra directory after running "grunt test" #799

wssbck opened this issue Dec 16, 2014 · 4 comments

Comments

@wssbck
Copy link
Contributor

wssbck commented Dec 16, 2014

I have noticed that after running:

grunt test

new directory shows up, namely:

web/docs/public/

Is this an intended behavior?

@gordonwoodhull
Copy link
Contributor

I've been having trouble with churn on check-ins recently, having to do with this directory. Pretty sure one of our doc building dependencies has changed and is building more stuff than it was.

But I haven't gotten as far as finding out what's causing it, whether the generated stuff is necessary, or what to do about it.

@paolodm
Copy link

paolodm commented Dec 22, 2014

I've verified that the web/docs/public folder is being generated on grunt docs task. See PR #808 for fix.

@gordonwoodhull
Copy link
Contributor

I added the directory to .gitignore, but I think it would also be fine not to build the docs when testing. Slightly different from #808 but close.

@gordonwoodhull
Copy link
Contributor

So I made the tests only depend on build, not docs - that was weird.

I dug as deep as determining that it's the grunt docco task that is adding this stuff. Docco is used to generate the annotated stock example. Indeed it looks like the page is missing some of the fancy styling that it used to have, because I haven't been checking in web/public/docs

With these fixes, I'm closing this - we can't do too much about all the transitive dependencies of our doc tools, but at least they won't be triggered for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants