Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dbt deps logging example #798

Merged
merged 7 commits into from
Sep 2, 2021

Conversation

sungchun12
Copy link
Contributor

Description & motivation

Illustrates to the developer how dbt deps version logging works.

To-do before merge

  • Ensure PR #3759 is merged

Pre-release docs

Is this change related to an unreleased version of dbt?

  • Yes: please
    • update the base branch to next
    • add Changelog components: <Changelog>[New/Changed] in v0.x.0</Changelog>
    • add links to the "New and changed documentation" section of the latest Migration Guide
  • No: please ensure the base branch is current
  • Unsure: we'll let you know!

@sungchun12 sungchun12 self-assigned this Aug 31, 2021
@sungchun12 sungchun12 requested a review from jtcohen6 August 31, 2021 17:11
@sungchun12 sungchun12 marked this pull request as ready for review August 31, 2021 17:12
@sungchun12 sungchun12 requested a review from annafil as a code owner August 31, 2021 17:12
Copy link
Collaborator

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thanks for opening the PR @sungchun12!

What do you think about including this sample output in the page for deps instead? I don't have a super strong feeling here, just thinking that the page on Packages is already quite dense with configuration options, and the page on deps is quite sparse by comparison.

@sungchun12
Copy link
Contributor Author

@jtcohen6 I agree with your suggestion! It gives the deps docs page a nice UX to understand what behavior it should produce upfront.

@sungchun12 sungchun12 requested a review from jtcohen6 September 2, 2021 13:59
Copy link
Collaborator

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for the excellent follow-through @sungchun12 :)

@sungchun12 sungchun12 merged commit cea30c5 into next Sep 2, 2021
@sungchun12 sungchun12 deleted the enhance-deps-package-version-logging-docs branch September 2, 2021 14:23
jtcohen6 pushed a commit that referenced this pull request Sep 20, 2021
jtcohen6 added a commit that referenced this pull request Oct 4, 2021
* new docs for on_schema_change (#747)

* Prerelease: v0.21.0-b1 (#756)

* Edits for on_schema_change

* dbt source freshness

* DBT_ENV_SECRET_ env var

* dbt build first cut

* Redshift profile ra3 property

* Beta callout in migration guide

* Self-review build docs

* Prerelease: v0.21.0-b2 (#767)

* state:modified subselectors, modified.macros

* Add build RPC method

* PR feedback

* add dbt deps logging example (#798)

* [Prerelease] Prep for 0.21.0-rc1 (#802)

* Switch --models to --select

* BQ snapshot config aliases

* Configurable postgres connect timeout

* Add list --output-keys. Add list RPC method

* Adapter unique_field dbt-labs/dbt-core#3796

* PR feedback: -s replaces -m

* Add BQ execution_project

* Add default property for yaml selectors

* Update migration guide. New fields in sources.json

* Test where config macro

* Dispatch for global macros

* Update build details

* Some self review

* Greedy flag/property for test selection

* Resolve #803 while we're here

* Fix broken link typo

* Refactor: configs + properties (#766)

* Very incomplete start of first draft

* Second big pass

* Initial self review. Sidebar reorg

* Continue self review. Address #616

* Add note to migration guide

* [Prerelease] v0.21 post-RC updates (#831)

* Artifact version bumps

* Add v0.20 -> v0.21 to Cloud upgrade FAQ

* PR feedback from jasnonaz <3

* [Release] v0.21.0 (#839)

* Update links, info in migration guides

* Fix v0.21 discourse link

Co-authored-by: matt-winkler <[email protected]>
Co-authored-by: Sung Won Chung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants