Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention sources "external:" property in the documentation #616

Closed
ecerulm opened this issue Mar 29, 2021 · 1 comment
Closed

Mention sources "external:" property in the documentation #616

ecerulm opened this issue Mar 29, 2021 · 1 comment
Assignees

Comments

@ecerulm
Copy link

ecerulm commented Mar 29, 2021

Steps to reproduce:

The fishtown-analytics/dbt-external-tables/README.md says:

dbt v0.15.0 added support for an external property within sources that can include information about location, partitions, and other database-specific properties.

There is no mention of this property external: in the dbt documentation, I would expect a mention to it in one of this places:

Expected results:

I would expect to see at least 1 reference to the source's external property in the documentation, at least mention it an point to https://github.com/fishtown-analytics/dbt-external-tables/blob/master/README.md,

Actual results

Extra details

@ecerulm ecerulm changed the title document: sources "external:" property Mention sources "external:" property in the documentation Mar 29, 2021
@jtcohen6 jtcohen6 self-assigned this Sep 14, 2021
jtcohen6 added a commit that referenced this issue Sep 14, 2021
jtcohen6 added a commit that referenced this issue Sep 20, 2021
* Very incomplete start of first draft

* Second big pass

* Initial self review. Sidebar reorg

* Continue self review. Address #616

* Add note to migration guide
jtcohen6 added a commit that referenced this issue Oct 4, 2021
* new docs for on_schema_change (#747)

* Prerelease: v0.21.0-b1 (#756)

* Edits for on_schema_change

* dbt source freshness

* DBT_ENV_SECRET_ env var

* dbt build first cut

* Redshift profile ra3 property

* Beta callout in migration guide

* Self-review build docs

* Prerelease: v0.21.0-b2 (#767)

* state:modified subselectors, modified.macros

* Add build RPC method

* PR feedback

* add dbt deps logging example (#798)

* [Prerelease] Prep for 0.21.0-rc1 (#802)

* Switch --models to --select

* BQ snapshot config aliases

* Configurable postgres connect timeout

* Add list --output-keys. Add list RPC method

* Adapter unique_field dbt-labs/dbt-core#3796

* PR feedback: -s replaces -m

* Add BQ execution_project

* Add default property for yaml selectors

* Update migration guide. New fields in sources.json

* Test where config macro

* Dispatch for global macros

* Update build details

* Some self review

* Greedy flag/property for test selection

* Resolve #803 while we're here

* Fix broken link typo

* Refactor: configs + properties (#766)

* Very incomplete start of first draft

* Second big pass

* Initial self review. Sidebar reorg

* Continue self review. Address #616

* Add note to migration guide

* [Prerelease] v0.21 post-RC updates (#831)

* Artifact version bumps

* Add v0.20 -> v0.21 to Cloud upgrade FAQ

* PR feedback from jasnonaz <3

* [Release] v0.21.0 (#839)

* Update links, info in migration guides

* Fix v0.21 discourse link

Co-authored-by: matt-winkler <[email protected]>
Co-authored-by: Sung Won Chung <[email protected]>
@jtcohen6
Copy link
Collaborator

jtcohen6 commented Oct 8, 2021

Added by #766!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants