Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow MultiOptions parameters to be listed multiple times #3003

Closed
1 task done
dbeatty10 opened this issue Mar 15, 2023 · 0 comments · Fixed by #3093
Closed
1 task done

Allow MultiOptions parameters to be listed multiple times #3003

dbeatty10 opened this issue Mar 15, 2023 · 0 comments · Fixed by #3093
Labels
content Improvements or additions to content dbt-core v1.5 Docs impact for the v1.5 release (Apr 2023) improvement Use this when an area of the docs needs improvement as it's currently unclear
Milestone
dbt Core v1.5 Doc...

Comments

@dbeatty10
Copy link
Contributor

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

Two pages to update

The changes in dbt-labs/dbt-core#7169 will spur the need to update multiple pages:

What part(s) of the page would you like to see updated?

YAML Selectors: exclude

The YAML Selectors says that:

This gets us more intricate subset definitions than what's available on the CLI, where we can only pass one "yeslist" (--select) and one "nolist" (--exclude).

At minimum, we'd need to update that portion if we merge option 1.

"What to know before upgrading" section in the release-specific notes

We will also want to call this out in the "What to know before upgrading" section in the release-specific notes:

dbt-labs/dbt-core#7169 describes how users could have silent parameters before that will no longer be silent. See dbt-labs/dbt-core#7158 and dbt-labs/dbt-core#6800 for more examples of the behavior we are fixing.

Additional information

No response
@dbeatty10 dbeatty10 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear dbt-core v1.5 Docs impact for the v1.5 release (Apr 2023) labels Mar 15, 2023
@dbeatty10 dbeatty10 added this to the dbt Core v1.5 Documentation milestone Mar 15, 2023
@dbeatty10 dbeatty10 mentioned this issue Mar 15, 2023
Merged
6 tasks
@dbeatty10 dbeatty10 added Needs tech review PRs that require an SME to review and removed Needs tech review PRs that require an SME to review labels Mar 21, 2023
@dbeatty10 dbeatty10 mentioned this issue Mar 28, 2023
Merged
3 tasks
dbeatty10 added a commit that referenced this issue Apr 3, 2023
@dbeatty10
Allow --select and --exclude multiple times in dbt 1.5 (#3093)
4954577 
resolves #3003

## What are you changing in this pull request and why?
See dbt-labs/dbt-core#7169 in addition to the
issues this resolves.

## Pages updated

- [Upgrading to
v1.5](https://deploy-preview-3093--docs-getdbt-com.netlify.app/guides/migration/versions/upgrading-to-v1.5#breaking-changes)
- [YAML
Selectors](https://deploy-preview-3093--docs-getdbt-com.netlify.app/reference/node-selection/yaml-selectors#exclude)
- [How does selection
work?](https://deploy-preview-3093--docs-getdbt-com.netlify.app/reference/node-selection/syntax#how-does-selection-work)

## 🎩 

[Netlify
preview](https://deploy-preview-3093--docs-getdbt-com.netlify.app/reference/node-selection/yaml-selectors#exclude)

### 1.4

<img width="500" alt="image"
src="https://user-images.githubusercontent.com/44704949/228322779-8b2f4d69-17a5-4326-8ced-7add389ebea0.png">

### 1.5

<img width="500" alt="image"
src="https://user-images.githubusercontent.com/44704949/228322883-08443f70-ea22-43db-a190-728b6e2e3b3c.png">

## Checklist
Uncomment if you're publishing docs for a prerelease version of dbt
(delete if not applicable):
- [x] Add versioning components, as described in [Versioning
Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/versioningdocs.md)
- [x] Add a note to the prerelease version [Migration
Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/guides/migration/versions)
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
and [About
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
so my content adheres to these guidelines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content Improvements or additions to content dbt-core v1.5 Docs impact for the v1.5 release (Apr 2023) improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
dbt Core v1.5 Documentation
Development

Successfully merging a pull request may close this issue.

Allow --select and --exclude multiple times in dbt 1.5 dbt-labs/docs.getdbt.com
1 participant
@dbeatty10