You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Did some manual testing by locally overwriting a command that accepts the new select (--select, --model) alias command with print(ctx.obj["flags"].SELECT) and found some issues when passing --select and --model to a command together.
The options are not treated as mutually exclusive via MultiOption and the resulting flags.SELECT value is clobbered by the value from the last alias option:
This was unexpected behaviour to me, but for better or for worse this is also how main's parsing currently works (printing args.select and exiting on main to test):
We should probably open an issue to document this behaviour and investigate a fix that gets us --select/--model option mutual exclusivity if possible. But given that it's the current behaviour on main I don't see it as pressing to fix as part of this PR.
The text was updated successfully, but these errors were encountered:
github-actionsbot
changed the title
Did some manual testing by locally overwriting a command that accepts the new select (--select, --model) alias command with print(ctx.obj["flags"].SELECT) and found some issues when passing --select and --model to a command together.
[CT-1981] Did some manual testing by locally overwriting a command that accepts the new select (--select, --model) alias command with print(ctx.obj["flags"].SELECT) and found some issues when passing --select and --model to a command together.
Jan 31, 2023
aranke
changed the title
[CT-1981] Did some manual testing by locally overwriting a command that accepts the new select (--select, --model) alias command with print(ctx.obj["flags"].SELECT) and found some issues when passing --select and --model to a command together.
[CT-1981] Issue when passing --select and --model to a command together
Jan 31, 2023
Did some manual testing by locally overwriting a command that accepts the new
select
(--select, --model) alias command withprint(ctx.obj["flags"].SELECT)
and found some issues when passing--select
and--model
to a command together.The options are not treated as mutually exclusive via MultiOption and the resulting
flags.SELECT
value is clobbered by the value from the last alias option:This was unexpected behaviour to me, but for better or for worse this is also how main's parsing currently works (printing args.select and exiting on main to test):
We should probably open an issue to document this behaviour and investigate a fix that gets us --select/--model option mutual exclusivity if possible. But given that it's the current behaviour on main I don't see it as pressing to fix as part of this PR.
Originally posted by @MichelleArk in #6787 (comment)
The text was updated successfully, but these errors were encountered: