Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate nose tests to pytest #1142

Merged
merged 286 commits into from
Feb 15, 2024
Merged

Migrate nose tests to pytest #1142

merged 286 commits into from
Feb 15, 2024

Conversation

ethho
Copy link
Contributor

@ethho ethho commented Dec 15, 2023

As scoped in PLAT-107, migrate the nose tests in tests_old to pytest-compatible tests in the tests directory. Since nose is not supported after Python v3.8, this is necessary if we want datajoint-python to support modern versions of Python.

In addition, fix and update the devcontainer development environment.

Component PRs

This PR contains changes made in the following PRs:

ethho and others added 30 commits December 4, 2023 23:00
PLAT-145: Migrate test_adapted_attributes.py
@A-Baji
Copy link
Collaborator

A-Baji commented Jan 2, 2024

@ethho I deleted the converted modules from tests_old in the PR for the first pass of the conversion. We probably want to revert that for archiving purposes.

@ethho ethho marked this pull request as ready for review January 3, 2024 20:21
@ethho
Copy link
Contributor Author

ethho commented Jan 3, 2024

@ethho I deleted the converted modules from tests_old in the PR for the first pass of the conversion. We probably want to revert that for archiving purposes.

I added these removed nosetests on 00c666a

Use latest tag as implemented in CI in
datajoint/nginx-docker#49
@dimitri-yatsenko dimitri-yatsenko merged commit 6dd57cc into master Feb 15, 2024
1 check passed
@dimitri-yatsenko dimitri-yatsenko deleted the dev-tests branch February 15, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-process Issues related to project management, tests, etc. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants