PLAT-146: Migrate test_aggr_regressions.py #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ethho
commented
Dec 8, 2023
ethho
commented
- cp to tests
- Migrate schema_uuid
- Fix test tests/test_aggr_regressions.py::test_left_join_len
- Tests pass with module scoped fixtures
- Fix fixtures
- If we skip these, test_union_join passes
- Skipping TestIssue558 passes all
- Tests passing with reordering
- test_aggr_regressions passing
- Construct schema_aggr_reg_with_abx separately
- Add context to diagram tests
Needs schema_uuid fixture, not schema_aggr_regress fixture
ethho
commented
Dec 8, 2023
|
|
||
| def test_union_join(schema_aggr_reg_with_abx): | ||
| """ | ||
| This test fails if it runs after TestIssue558. |
There was a problem hiding this comment.
TODO: Document this as a known GitHub Issue after we merge dev-tests to trunk.
A-Baji
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.