Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH DEBT]: Consistent naming with access controls #3002

Open
1 task done
Tracked by #2967
JCZuurmond opened this issue Oct 17, 2024 · 0 comments
Open
1 task done
Tracked by #2967

[TECH DEBT]: Consistent naming with access controls #3002

JCZuurmond opened this issue Oct 17, 2024 · 0 comments
Labels
migrate/access-control Access Control to things tech debt chores and design flaws

Comments

@JCZuurmond
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Problem statement

Currently, we mix naming of access control related resources which makes it confusing to read the code.

Definitions

Notes

  • A "grant" is a verb (like "revoke") while in our code it is a noun
  • Privileges on securable objects are inferred from ACLs to compute resources:
    • get_interactive_cluster_grants -> infer_privileges_from_compute_access_control_lists (leaving "securable objects" out of the name for brevity)
  • Principal in PrincipalACL is redundant as a access control list (ACL) is always assigned (assignment) to a principal. test_principal_grants.py
  • I do not know the difference between permissions and privileges (yet). I think permissions are only assigned to workspace level objects, where privileges are assigned to securable data objects.

Please extend where I missed.

Proposed Solution

Go over the documentation and apply naming consistently in the code. Also document the definitions from the online databricks documentation in our code.

Additional Context

No response

@JCZuurmond JCZuurmond added enhancement New feature or request needs-triage migrate/access-control Access Control to things labels Oct 17, 2024
@JCZuurmond JCZuurmond added this to UCX Oct 17, 2024
@github-project-automation github-project-automation bot moved this to Triage in UCX Oct 17, 2024
JCZuurmond added a commit that referenced this issue Oct 17, 2024
JCZuurmond added a commit that referenced this issue Oct 17, 2024
@nfx nfx removed the needs-triage label Oct 17, 2024
@nfx nfx moved this from Triage to Quarter Backlog in UCX Oct 17, 2024
@nfx nfx added tech debt chores and design flaws and removed enhancement New feature or request labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migrate/access-control Access Control to things tech debt chores and design flaws
Projects
Status: No status
Development

No branches or pull requests

2 participants