Skip to content

Commit

Permalink
Remove TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
JCZuurmond committed Oct 17, 2024
1 parent 3e1c51b commit 8a99a2b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tests/integration/hive_metastore/test_catalog_schema.py
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def test_create_catalog_schema_with_principal_acl_aws(


@retried(on=[NotFound], timeout=timedelta(minutes=3))
def test_create_catalog_schema_with_legacy_hive_metastore_privileges( # TODO: Issue about ACL vs grants vs privileges
def test_create_catalog_schema_with_legacy_hive_metastore_privileges(
ws: WorkspaceClient,
runtime_ctx,
make_random,
Expand Down Expand Up @@ -191,6 +191,7 @@ def test_create_catalog_schema_when_users_group_in_warehouse_acl(
rule = Rule("workspace", dst_catalog_name, src_schema.name, dst_schema_name, src_table.name, src_table.name)
runtime_ctx.with_table_mapping_rules([rule])
runtime_ctx.with_dummy_resource_permission()
runtime_ctx.make_group()
warehouse = make_warehouse()
make_warehouse_permissions(object_id=warehouse.id, permission_level=PermissionLevel.CAN_USE, group_name="users")
mock_prompts = MockPrompts({"Please provide storage location url for catalog: *": ""})
Expand Down

0 comments on commit 8a99a2b

Please sign in to comment.