Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix progress_stream teardown #5823

Merged
merged 1 commit into from
Mar 3, 2022
Merged

fix progress_stream teardown #5823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions distributed/diagnostics/progress_stream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import logging
from functools import partial

from tlz import merge, valmap

from ..core import coerce_to_address, connect
from ..scheduler import Scheduler
from ..utils import color_of, key_split
from ..worker import dumps_function
from .progress import AllProgress
Expand All @@ -22,10 +20,10 @@ def counts(scheduler, allprogress):
)


def remove_plugin(**kwargs):
def _remove_all_progress_plugin(self, *args, **kwargs):
# Wrapper function around `Scheduler.remove_plugin` to avoid raising a
# `PicklingError` when using a cythonized scheduler
return Scheduler.remove_plugin(**kwargs)
self.remove_plugin(name=AllProgress.name)


async def progress_stream(address, interval):
Expand Down Expand Up @@ -54,7 +52,7 @@ async def progress_stream(address, interval):
"setup": dumps_function(AllProgress),
"function": dumps_function(counts),
"interval": interval,
"teardown": dumps_function(partial(remove_plugin, name=AllProgress.name)),
"teardown": dumps_function(_remove_all_progress_plugin),
}
)
return comm
Expand Down