fix progress_stream teardown #5823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
force-pushed
the
fix-all-progress-stream-plugin-teardown
branch
2 times, most recently
from
2ab5a76 to
b98acd7
Compare
Unit Test Results 12 files ±0 12 suites ±0 7h 3m 45s ⏱️ - 18m 16s For more details on these failures and errors, see this check. Results for commit 2ae4e38. ± Comparison against base commit 60d82c2. ♻️ This comment has been updated with latest results. |
graingert
force-pushed
the
fix-all-progress-stream-plugin-teardown
branch
from
b98acd7 to
2ae4e38
Compare
ian-r-rose
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeError: remove_plugin() takes 0 positional arguments but 2 were given#5747pre-commit run --all-filesIt's tricky to test this because the exception is logged after the
gen_clusterfinishes