Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfail test_preload_remote_module #3778

Closed
wants to merge 2 commits into from
Closed

Conversation

jrbourbeau
Copy link
Member

This PR xfails test_preload_remote_module as a temporary patch until #3774 is resolved (#3775 is close)

cc @jcrist

@jcrist
Copy link
Member

jcrist commented May 6, 2020

LGTM, thanks @jrbourbeau

@jrbourbeau
Copy link
Member Author

I've updated #3775 to include a fix from @mrocklin. The underlying issue with test_preload_remote_module comes from #3777, so with the fix we try Client.run_on_scheduler a few times to allow the scheduler to finish starting up. We will be able to revert making multiple run_on_scheduler calls when #3777 is resolved.

Closing this PR in favor of #3775. Sorry for all the back and forth @jcrist

@jrbourbeau jrbourbeau closed this May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants