-
-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to fix test_preload_remote_module on windows #3775
Conversation
Thank you for working to resolve this @jrbourbeau . I appreciate it. |
Hrm, I tried pushing the following commit to your branch but wasn't able to. Odd. diff --git a/distributed/cli/tests/test_dask_scheduler.py b/distributed/cli/tests/test_dask_scheduler.py
index d5c0d9c7..fc7469ec 100644
--- a/distributed/cli/tests/test_dask_scheduler.py
+++ b/distributed/cli/tests/test_dask_scheduler.py
@@ -305,6 +305,11 @@ def test_preload_remote_module(loop, tmp_path):
f.write(PRELOAD_TEXT)
with popen([sys.executable, "-m", "http.server", "9382"], cwd=tmp_path):
+ import requests
+
+ data = requests.get("http://localhost:9382/scheduler_info.py").content
+ assert b"scheduler.foo" in data
+
with popen(
[
"dask-scheduler", |
OK, I broke open the Windows partition. The issue was this #3777 Client.run was running before the preload had a chance to finish. I've resolved the test short term with jrbourbeau#1 |
There is a nicer solution in there now |
Thanks for fixing this @mrocklin! |
Could this PR be merged? - Asking for other PR's which are blocked by CI failures |
Thanks @mrocklin !! 🎉 |
Thanks for the poke :) |
No description provided.