[MRG] Bug-Fix in Polynomial-Features #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened dask/dask-glm#72 in relation to some of the test failures here. Usage of |
Merged
|
I'll rebase hopefully, later today |
datajanko
force-pushed
the
poly-bug-fix
branch
from
cdbaacc to
d4ce2b9
Compare
|
@datajanko it should be okay to rebase now, the errors showing up here have been fixed in |
added 2 commits
October 25, 2018 21:52
parameters are not recognized during fitting
datajanko
force-pushed
the
poly-bug-fix
branch
from
d4ce2b9 to
d716725
Compare
datajanko
changed the title
datajanko
changed the title
datajanko
changed the title
datajanko
commented
Oct 26, 2018
| degree=self.degree, | ||
| interaction_only=self.interaction_only, | ||
| include_bias=self.include_bias, | ||
| ) |
There was a problem hiding this comment.
can this be made more elegant using super?
There was a problem hiding this comment.
I don't think so. We're composing our class with a separate scikit-learn PolynomialFeatures. Using super would be a way to call a method of the parent class, passing ourself as the self.
|
Thanks for the patience with the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #366 I realized that the PolynomialFeatures transformer does not respect the passed parameters correctly. The PR fixes this and provides a test