Merge pull request #417 from datajanko/poly-bug-fix

[MRG] Bug-Fix in Polynomial-Features
dask · Oct 30, 2018 · 33c9438 · 33c9438
2 parents ce6b337 + d716725
commit 33c9438
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/dask_ml/preprocessing/data.py b/dask_ml/preprocessing/data.py
@@ -945,7 +945,11 @@ def __init__(
         self.preserve_dataframe = preserve_dataframe
 
     def fit(self, X, y=None):
-        self._transformer = skdata.PolynomialFeatures()
+        self._transformer = skdata.PolynomialFeatures(
+            degree=self.degree,
+            interaction_only=self.interaction_only,
+            include_bias=self.include_bias,
+        )
         X_sample = X
         if isinstance(X, dd.DataFrame):
             X_sample = X._meta_nonempty

diff --git a/tests/preprocessing/test_data.py b/tests/preprocessing/test_data.py
@@ -553,3 +553,10 @@ def test_df_transform(self, daskify):
             assert_eq_df(res_df.compute().reset_index(drop=True), res_pandas)
         assert_eq_ar(res_df.values, res_c)
         assert_eq_ar(res_df.values, res_arr)
+
+    def test_transformer_params(self):
+        pf = dpp.PolynomialFeatures(degree=3, interaction_only=True, include_bias=False)
+        pf.fit(X)
+        assert pf._transformer.degree == pf.degree
+        assert pf._transformer.interaction_only is pf.interaction_only
+        assert pf._transformer.include_bias is pf.include_bias