fix(platform)!: data contract validation improvements

packages/js-dash-sdk/src/SDK/Client/Platform/methods/identities/internal/createIdentityCreateTransition.ts

@@ -40,6 +40,7 @@ export async function createIdentityCreateTransition(
 
   const keyOne = new IdentityPublicKey(1);
   keyOne.setData(identityMasterPublicKey.toBuffer());
+  keyOne.setSecurityLevel(IdentityPublicKey.SECURITY_LEVELS.MASTER);
 
   const keyTwo = new IdentityPublicKey(1);
   keyTwo.setId(1);

packages/js-dash-sdk/src/test/fixtures/createIdentityFixtureInAccount.ts

@@ -16,6 +16,7 @@ export async function createIdentityFixtureInAccount(account) {
 
   const publicKeyOne = new IdentityPublicKey(1);
   publicKeyOne.setData(identityMasterPrivateKey.toPublicKey().toBuffer());
+  publicKeyOne.setSecurityLevel(IdentityPublicKey.SECURITY_LEVELS.MASTER);
 
   const publicKeyTwo = new IdentityPublicKey(1);
   publicKeyTwo.setId(1);

packages/rs-dpp/src/data_contract/accessors/mod.rs

@@ -4,9 +4,10 @@ use crate::data_contract::document_type::{DocumentType, DocumentTypeRef};
 use crate::data_contract::DocumentName;
 use crate::metadata::Metadata;
 use crate::prelude::DataContract;
-use crate::ProtocolError;
+
 use platform_value::Identifier;
 
+use crate::data_contract::errors::DataContractError;
 use std::collections::BTreeMap;
 
 pub mod v0;
@@ -36,13 +37,13 @@ impl DataContractV0Getters for DataContract {
         }
     }
 
-    fn document_type_cloned_for_name(&self, name: &str) -> Result<DocumentType, ProtocolError> {
+    fn document_type_cloned_for_name(&self, name: &str) -> Result<DocumentType, DataContractError> {
         match self {
             DataContract::V0(v0) => v0.document_type_cloned_for_name(name),
         }
     }
 
-    fn document_type_for_name(&self, name: &str) -> Result<DocumentTypeRef, ProtocolError> {
+    fn document_type_for_name(&self, name: &str) -> Result<DocumentTypeRef, DataContractError> {
         match self {
             DataContract::V0(v0) => v0.document_type_for_name(name),
         }

packages/rs-dpp/src/data_contract/accessors/v0/mod.rs

@@ -1,8 +1,9 @@
 use crate::data_contract::config::DataContractConfig;
 use crate::data_contract::document_type::{DocumentType, DocumentTypeRef};
+use crate::data_contract::errors::DataContractError;
 use crate::data_contract::DocumentName;
 use crate::metadata::Metadata;
-use crate::ProtocolError;
+
 use platform_value::Identifier;
 use std::collections::BTreeMap;
 
@@ -17,10 +18,10 @@ pub trait DataContractV0Getters {
 
     /// Returns the identifier of the contract owner.
     fn owner_id(&self) -> Identifier;
-    fn document_type_cloned_for_name(&self, name: &str) -> Result<DocumentType, ProtocolError>;
+    fn document_type_cloned_for_name(&self, name: &str) -> Result<DocumentType, DataContractError>;
 
     /// Returns the document type for the given document name.
-    fn document_type_for_name(&self, name: &str) -> Result<DocumentTypeRef, ProtocolError>;
+    fn document_type_for_name(&self, name: &str) -> Result<DocumentTypeRef, DataContractError>;
 
     fn document_type_optional_for_name(&self, name: &str) -> Option<DocumentTypeRef>;
     fn document_type_cloned_optional_for_name(&self, name: &str) -> Option<DocumentType>;

packages/rs-dpp/src/data_contract/config/methods/validate_config_update/mod.rs

@@ -21,7 +21,7 @@ impl DataContractConfig {
         {
             0 => Ok(self.validate_config_update_v0(new_config, contract_id)),
             version => Err(ProtocolError::UnknownVersionMismatch {
-                method: "DataContractConfig::from_value".to_string(),
+                method: "validate_config_update".to_string(),
                 known_versions: vec![0],
                 received: version,
             }),

packages/rs-dpp/src/data_contract/config/methods/validate_config_update/v0/mod.rs

@@ -11,12 +11,16 @@ impl DataContractConfig {
         new_config: &DataContractConfig,
         contract_id: Identifier,
     ) -> SimpleConsensusValidationResult {
+        // Validate: Old contract is not read_only
+
         if self.readonly() {
             return SimpleConsensusValidationResult::new_with_error(
                 DataContractIsReadonlyError::new(contract_id).into(),
             );
         }
 
+        // Validate: New contract is not read_only
+
         if new_config.readonly() {
             return SimpleConsensusValidationResult::new_with_error(
                 DataContractConfigUpdateError::new(
@@ -27,6 +31,8 @@ impl DataContractConfig {
             );
         }
 
+        // Validate: Keeps history did not change
+
         if new_config.keeps_history() != self.keeps_history() {
             return SimpleConsensusValidationResult::new_with_error(
                 DataContractConfigUpdateError::new(
@@ -41,6 +47,8 @@ impl DataContractConfig {
             );
         }
 
+        // Validate: Can be deleted did not change
+
         if new_config.can_be_deleted() != self.can_be_deleted() {
             return SimpleConsensusValidationResult::new_with_error(
                 DataContractConfigUpdateError::new(
@@ -55,6 +63,8 @@ impl DataContractConfig {
             );
         }
 
+        // Validate: Documents keep history did not change
+
         if new_config.documents_keep_history_contract_default()
             != self.documents_keep_history_contract_default()
         {
@@ -67,6 +77,8 @@ impl DataContractConfig {
             );
         }
 
+        // Validate: Documents mutable contract default did not change
+
         if new_config.documents_mutable_contract_default()
             != self.documents_mutable_contract_default()
         {
@@ -79,6 +91,8 @@ impl DataContractConfig {
             );
         }
 
+        // Validate: Requires identity encryption bounded key did not change
+
         if new_config.requires_identity_encryption_bounded_key()
             != self.requires_identity_encryption_bounded_key()
         {
@@ -91,6 +105,8 @@ impl DataContractConfig {
             );
         }
 
+        // Validate: Requires identity decryption bounded key did not change
+
         if new_config.requires_identity_decryption_bounded_key()
             != self.requires_identity_decryption_bounded_key()
         {

packages/rs-dpp/src/data_contract/document_type/class_methods/create_document_types_from_document_schemas/mod.rs

@@ -82,7 +82,7 @@ mod test {
             false,
             false,
             false,
-            &crate::version::PlatformVersion::latest(),
+            crate::version::PlatformVersion::latest(),
         );
 
         match result {