fix(platform)!: data contract validation improvements #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dashpay/platform into feat/betterDataContractUpdateProcessing
QuantumExplorer
changed the title
QuantumExplorer
changed the base branch from
v1.0-dev
to
fix-identity-add-keys-in-strategies
QuantumExplorer
changed the base branch from
fix-identity-add-keys-in-strategies
to
v1.0-dev
QuantumExplorer
changed the title
QuantumExplorer
changed the title
shumkov
requested changes
Mar 13, 2024
packages/rs-dpp/src/data_contract/document_type/class_methods/try_from_schema/v0/mod.rs
Show resolved
Hide resolved
packages/rs-dpp/src/data_contract/document_type/class_methods/try_from_schema/v0/mod.rs
Show resolved
Hide resolved
packages/rs-dpp/src/data_contract/document_type/class_methods/try_from_schema/v0/mod.rs
Show resolved
Hide resolved
shumkov
reviewed
Mar 13, 2024
shumkov
reviewed
Mar 13, 2024
shumkov
reviewed
Mar 13, 2024
shumkov
reviewed
Mar 13, 2024
shumkov
reviewed
Mar 13, 2024
packages/rs-drive-abci/src/execution/validation/state_transition/processor/v0/mod.rs
Outdated
Show resolved
Hide resolved
…dashpay/platform into feat/betterDataContractUpdateProcessing
shumkov
requested changes
Mar 14, 2024
packages/rs-drive/src/drive/batch/transitions/contract/data_contract_create_transition.rs
Outdated
Show resolved
Hide resolved
…dashpay/platform into feat/betterDataContractUpdateProcessing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Data contracts were being validated twice, once on advanced structure validation and once when transforming into an action. Now we will only do the validation when transforming into an action.
Data contract validation was littered with many different types of errors. Only consensus errors would give back a user based error.
What was done?
We will only do advanced structure validation for contract transitions when transforming into an action.
In this PR we modified all errors that could be user based to be consensus errors.
How Has This Been Tested?
Tests still pass.
Breaking Changes
This is more a fix than a breaking change, however since the system will behave differently we can categorize the changes as breaking.
Checklist:
For repository code-owners and collaborators only