Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make strategy start identities a new struct #1764

Merged
merged 3 commits into from
Mar 14, 2024
Merged

refactor: make strategy start identities a new struct #1764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7222149
refactor: make strategy start identities a new struct
pauldelucia Mar 11, 2024
bdeddb6
fix: add proper comments for StartIdentities
pauldelucia Mar 11, 2024
d2be785
Merge branch 'v1.0-dev' into refactor-start-identities-again
pauldelucia Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/rs-drive-abci/tests/strategy_tests/chain_lock_update.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ mod tests {

use drive_abci::test::helpers::setup::TestPlatformBuilder;
use strategy_tests::frequency::Frequency;
use strategy_tests::Strategy;
use strategy_tests::{StartIdentities, Strategy};

#[test]
fn run_chain_lock_update_quorums_not_changing() {
Expand All @@ -18,7 +18,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: Default::default(),
chance_per_block: None,
Expand Down
8 changes: 4 additions & 4 deletions packages/rs-drive-abci/tests/strategy_tests/core_update_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@ mod tests {
use drive_abci::platform_types::validator_set::v0::ValidatorSetV0Getters;
use drive_abci::test::helpers::setup::TestPlatformBuilder;
use strategy_tests::frequency::Frequency;
use strategy_tests::Strategy;
use strategy_tests::{StartIdentities, Strategy};

#[test]
fn run_chain_random_bans() {
let strategy = NetworkStrategy {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: Default::default(),
chance_per_block: None,
Expand Down Expand Up @@ -117,7 +117,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: Default::default(),
chance_per_block: None,
Expand Down Expand Up @@ -203,7 +203,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: Default::default(),
chance_per_block: None,
Expand Down
6 changes: 3 additions & 3 deletions packages/rs-drive-abci/tests/strategy_tests/failures.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ mod tests {
use strategy_tests::frequency::Frequency;

use crate::strategy::{FailureStrategy, NetworkStrategy};
use strategy_tests::Strategy;
use strategy_tests::{StartIdentities, Strategy};

use drive_abci::config::{ExecutionConfig, PlatformConfig, PlatformTestConfig};

Expand Down Expand Up @@ -57,7 +57,7 @@ mod tests {
Some(BTreeMap::from([(3, contract_update_1)])),
)],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: 1..2,
chance_per_block: None,
Expand Down Expand Up @@ -134,7 +134,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: Default::default(),
chance_per_block: None,
Expand Down
69 changes: 35 additions & 34 deletions packages/rs-drive-abci/tests/strategy_tests/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ mod tests {
use dashcore_rpc::dashcore_rpc_json::{AssetUnlockStatus, ExtendedQuorumDetails};
use dashcore_rpc::json::AssetUnlockStatusResult;
use dpp::block::extended_block_info::v0::ExtendedBlockInfoV0Getters;
use strategy_tests::StartIdentities;
use std::sync::{Arc, Mutex};
use strategy_tests::operations::DocumentAction::DocumentActionReplace;
use strategy_tests::operations::{
Expand Down Expand Up @@ -145,7 +146,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: Default::default(),
chance_per_block: None,
Expand Down Expand Up @@ -191,7 +192,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: Default::default(),
chance_per_block: None,
Expand Down Expand Up @@ -238,7 +239,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: Default::default(),
chance_per_block: None,
Expand Down Expand Up @@ -366,7 +367,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: Default::default(),
chance_per_block: None,
Expand Down Expand Up @@ -501,7 +502,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: 1..2,
chance_per_block: None,
Expand Down Expand Up @@ -562,7 +563,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: Default::default(),
chance_per_block: None,
Expand Down Expand Up @@ -612,7 +613,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: Default::default(),
chance_per_block: None,
Expand Down Expand Up @@ -670,7 +671,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: Default::default(),
chance_per_block: None,
Expand Down Expand Up @@ -733,7 +734,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: Default::default(),
chance_per_block: None,
Expand Down Expand Up @@ -809,7 +810,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: Default::default(),
chance_per_block: None,
Expand Down Expand Up @@ -874,7 +875,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: Default::default(),
chance_per_block: None,
Expand Down Expand Up @@ -942,7 +943,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: Default::default(),
chance_per_block: None,
Expand Down Expand Up @@ -1037,7 +1038,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: 1..2,
chance_per_block: None,
Expand Down Expand Up @@ -1091,7 +1092,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: 1..2,
chance_per_block: None,
Expand Down Expand Up @@ -1169,7 +1170,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![(contract, None)],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: 1..2,
chance_per_block: None,
Expand Down Expand Up @@ -1276,7 +1277,7 @@ mod tests {
])),
)],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: 1..2,
chance_per_block: None,
Expand Down Expand Up @@ -1376,7 +1377,7 @@ mod tests {
chance_per_block: None,
},
}],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: 1..2,
chance_per_block: None,
Expand Down Expand Up @@ -1452,7 +1453,7 @@ mod tests {
chance_per_block: None,
},
}],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: 1..2,
chance_per_block: None,
Expand Down Expand Up @@ -1556,7 +1557,7 @@ mod tests {
},
},
],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: 1..2,
chance_per_block: None,
Expand Down Expand Up @@ -1660,7 +1661,7 @@ mod tests {
},
},
],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: 1..2,
chance_per_block: None,
Expand Down Expand Up @@ -1779,7 +1780,7 @@ mod tests {
},
},
],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: 1..2,
chance_per_block: None,
Expand Down Expand Up @@ -1900,7 +1901,7 @@ mod tests {
},
},
],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: 1..2,
chance_per_block: None,
Expand Down Expand Up @@ -2010,7 +2011,7 @@ mod tests {
},
},
],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: 1..2,
chance_per_block: None,
Expand Down Expand Up @@ -2120,7 +2121,7 @@ mod tests {
},
},
],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: 1..30,
chance_per_block: None,
Expand Down Expand Up @@ -2244,7 +2245,7 @@ mod tests {
},
},
],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: 1..6,
chance_per_block: None,
Expand Down Expand Up @@ -2312,7 +2313,7 @@ mod tests {
chance_per_block: None,
},
}],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: 1..2,
chance_per_block: None,
Expand Down Expand Up @@ -2386,7 +2387,7 @@ mod tests {
chance_per_block: None,
},
}],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: 1..2,
chance_per_block: None,
Expand Down Expand Up @@ -2467,7 +2468,7 @@ mod tests {
chance_per_block: None,
},
}],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: 1..2,
chance_per_block: None,
Expand Down Expand Up @@ -2556,7 +2557,7 @@ mod tests {
},
},
],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: 1..2,
chance_per_block: None,
Expand Down Expand Up @@ -3112,7 +3113,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
//we do this to create some paying transactions
times_per_block_range: 1..2,
Expand Down Expand Up @@ -3272,7 +3273,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
//we do this to create some paying transactions
times_per_block_range: 1..2,
Expand Down Expand Up @@ -3403,7 +3404,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
//we do this to create some paying transactions
times_per_block_range: 1..2,
Expand Down Expand Up @@ -3535,7 +3536,7 @@ mod tests {
strategy: Strategy {
contracts_with_updates: vec![],
operations: vec![],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: Default::default(),
chance_per_block: None,
Expand Down Expand Up @@ -3668,7 +3669,7 @@ mod tests {
chance_per_block: None,
},
}],
start_identities: (0, 0),
start_identities: StartIdentities::default(),
identities_inserts: Frequency {
times_per_block_range: 6..10,
chance_per_block: None,
Expand Down
Loading
Loading