Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make strategy start identities a new struct #1764

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

pauldelucia
Copy link
Member

Issue being fixed or feature implemented

The way of making Strategy start_identities a tuple of u8s was ugly, so we made it a struct StartIdentities. We also added an optional field where the starting balance of each identity can be specified, in addition to the number of identities and keys per identity.

What was done?

See above

How Has This Been Tested?

Strategy tests in Platform TUI

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer merged commit 8405c30 into v1.0-dev Mar 14, 2024
23 checks passed
@QuantumExplorer QuantumExplorer deleted the refactor-start-identities-again branch March 14, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants