refactor: drop unused includes; use calculate_sign_hash #1540
PastaPastaPastatests.yml
on: pull_request
Build JS packages
/
Build JS
2m 26s
Matrix: Build Docker images
Determine changed packages
15s
Rust crates security audit
36s
JS dependency versions check
10s
JS NPM security audit
13s
JS code security audit
/
Run Code QL
2m 19s
Packages functional tests
/
Run functional tests
4m 6s
Matrix: Test Suite
Matrix: Dashmate E2E tests
Waiting for pending jobs
Matrix: JS packages
Waiting for pending jobs
Matrix: Rust packages
Annotations
1 error and 56 warnings
|
Tests
Error when evaluating 'strategy' for job 'js-packages'. .github/workflows/tests.yml (Line: 115, Col: 21): Matrix vector 'js-package' does not contain any values
|
|
JS dependency versions check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Determine changed packages
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, dorny/paths-filter@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Rust crates security audit
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: rustsec/audit-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Rust crates security audit
4 warnings found!
|
|
Rust crates security audit
Unknown warning kind unsound found, please, file a bug
|
|
Rust crates security audit
Unknown warning kind unsound found, please, file a bug
|
|
Rust packages (drive) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Rust packages (drive) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Rust packages (rs-sdk) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Rust packages (rs-sdk) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Rust packages (drive-abci) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Rust packages (drive-abci) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Rust packages (drive) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
unused import: `UserFeeIncrease`:
packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/methods/mod.rs#L9
warning: unused import: `UserFeeIncrease`
--> packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/methods/mod.rs:9:37
|
9 | use crate::prelude::{IdentityNonce, UserFeeIncrease};
| ^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
unused import: `UserFeeIncrease`:
packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/methods/v0/mod.rs#L10
warning: unused import: `UserFeeIncrease`
--> packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/methods/v0/mod.rs:10:37
|
10 | use crate::prelude::{IdentityNonce, UserFeeIncrease};
| ^^^^^^^^^^^^^^^
|
|
unused import: `UserFeeIncrease`:
packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/v0/v0_methods.rs#L11
warning: unused import: `UserFeeIncrease`
--> packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/v0/v0_methods.rs:11:37
|
11 | use crate::prelude::{IdentityNonce, UserFeeIncrease};
| ^^^^^^^^^^^^^^^
|
|
unused import: `UserFeeIncrease`:
packages/rs-dpp/src/state_transition/state_transitions/identity/identity_update_transition/v0/v0_methods.rs#L22
warning: unused import: `UserFeeIncrease`
--> packages/rs-dpp/src/state_transition/state_transitions/identity/identity_update_transition/v0/v0_methods.rs:22:37
|
22 | use crate::prelude::{IdentityNonce, UserFeeIncrease};
| ^^^^^^^^^^^^^^^
|
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-drive/src/drive/identity/contract_info/keys/mod.rs#L44
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-drive/src/drive/identity/contract_info/keys/mod.rs:44:10
|
44 | ) -> (
| __________^
45 | | BTreeMap<String, Vec<(KeyID, Purpose)>>,
46 | | Vec<(KeyID, Purpose)>,
47 | | ) {
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-drive/src/drive/verify/contract/verify_contract/v0/mod.rs#L173
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-drive/src/drive/verify/contract/verify_contract/v0/mod.rs:173:10
|
173 | ) -> Result<(RootHash, BTreeMap<[u8; 32], Option<DataContract>>), Error> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-drive/src/query/conditions.rs#L465
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-drive/src/query/conditions.rs:465:10
|
465 | ) -> Result<(BTreeMap<String, Self>, Option<Self>, Option<Self>), Error> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
Rust packages (drive-abci) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
unused import: `UserFeeIncrease`:
packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/methods/mod.rs#L9
warning: unused import: `UserFeeIncrease`
--> packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/methods/mod.rs:9:37
|
9 | use crate::prelude::{IdentityNonce, UserFeeIncrease};
| ^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
unused import: `UserFeeIncrease`:
packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/methods/v0/mod.rs#L10
warning: unused import: `UserFeeIncrease`
--> packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/methods/v0/mod.rs:10:37
|
10 | use crate::prelude::{IdentityNonce, UserFeeIncrease};
| ^^^^^^^^^^^^^^^
|
|
unused import: `UserFeeIncrease`:
packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/v0/v0_methods.rs#L11
warning: unused import: `UserFeeIncrease`
--> packages/rs-dpp/src/state_transition/state_transitions/document/documents_batch_transition/v0/v0_methods.rs:11:37
|
11 | use crate::prelude::{IdentityNonce, UserFeeIncrease};
| ^^^^^^^^^^^^^^^
|
|
unused import: `UserFeeIncrease`:
packages/rs-dpp/src/state_transition/state_transitions/identity/identity_update_transition/v0/v0_methods.rs#L22
warning: unused import: `UserFeeIncrease`
--> packages/rs-dpp/src/state_transition/state_transitions/identity/identity_update_transition/v0/v0_methods.rs:22:37
|
22 | use crate::prelude::{IdentityNonce, UserFeeIncrease};
| ^^^^^^^^^^^^^^^
|
|
module has the same name as its containing module:
packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/mod.rs#L11
warning: module has the same name as its containing module
--> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/mod.rs:11:1
|
11 | mod update_masternode_identities;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `#[warn(clippy::module_inception)]` on by default
|
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L58
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:58:56
|
58 | pub previous_height_chain_lock_validating_quorums: Option<(
| ________________________________________________________^
59 | | u32,
60 | | u32,
61 | | Option<u32>,
62 | | BTreeMap<QuorumHash, ThresholdBlsPublicKey>,
63 | | )>,
| |______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L143
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:143:9
|
143 | Option<(u32, u32, Option<u32>, Vec<(Bytes32, ThresholdBlsPublicKey)>)>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L438
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:438:10
|
438 | ) -> &mut Option<(
| __________^
439 | | u32,
440 | | u32,
441 | | Option<u32>,
442 | | BTreeMap<QuorumHash, ThresholdBlsPublicKey>,
443 | | )>;
| |______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L459
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:459:10
|
459 | ) -> Option<&(
| __________^
460 | | u32,
461 | | u32,
462 | | Option<u32>,
463 | | BTreeMap<QuorumHash, ThresholdBlsPublicKey>,
464 | | )>;
| |______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
Build JS packages / Build JS
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update, actions/setup-node@v3, mozilla-actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Rust packages (drive-abci) / Check each feature
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Rust packages (rs-sdk) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
unused import: `dpp::prelude::Identifier`:
packages/rs-drive/src/common/mod.rs#L63
warning: unused import: `dpp::prelude::Identifier`
--> packages/rs-drive/src/common/mod.rs:63:5
|
63 | use dpp::prelude::Identifier;
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
unused import: `dpp::version::PlatformVersion`:
packages/rs-drive/src/common/mod.rs#L67
warning: unused import: `dpp::version::PlatformVersion`
--> packages/rs-drive/src/common/mod.rs:67:5
|
67 | use dpp::version::PlatformVersion;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `dpp::data_contracts`:
packages/rs-drive/src/drive/contract/contract_fetch_info.rs#L3
warning: unused import: `dpp::data_contracts`
--> packages/rs-drive/src/drive/contract/contract_fetch_info.rs:3:5
|
3 | use dpp::data_contracts;
| ^^^^^^^^^^^^^^^^^^^
|
|
unused import: `dpp::system_data_contracts::load_system_data_contract`:
packages/rs-drive/src/drive/contract/contract_fetch_info.rs#L5
warning: unused import: `dpp::system_data_contracts::load_system_data_contract`
--> packages/rs-drive/src/drive/contract/contract_fetch_info.rs:5:5
|
5 | use dpp::system_data_contracts::load_system_data_contract;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `platform_version::version::PlatformVersion`:
packages/rs-drive/src/drive/contract/contract_fetch_info.rs#L13
warning: unused import: `platform_version::version::PlatformVersion`
--> packages/rs-drive/src/drive/contract/contract_fetch_info.rs:13:5
|
13 | use platform_version::version::PlatformVersion;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `dpp::fee::SignedCredits`:
packages/rs-drive/src/drive/credit_pools/mod.rs#L50
warning: unused import: `dpp::fee::SignedCredits`
--> packages/rs-drive/src/drive/credit_pools/mod.rs:50:5
|
50 | use dpp::fee::SignedCredits;
| ^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `crate::drive::defaults::DEFAULT_HASH_SIZE_U8`:
packages/rs-drive/src/drive/document/mod.rs#L37
warning: unused import: `crate::drive::defaults::DEFAULT_HASH_SIZE_U8`
--> packages/rs-drive/src/drive/document/mod.rs:37:5
|
37 | use crate::drive::defaults::DEFAULT_HASH_SIZE_U8;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `dpp::data_contract::document_type::accessors::DocumentTypeV0Getters`:
packages/rs-drive/src/drive/document/mod.rs#L42
warning: unused import: `dpp::data_contract::document_type::accessors::DocumentTypeV0Getters`
--> packages/rs-drive/src/drive/document/mod.rs:42:5
|
42 | use dpp::data_contract::document_type::accessors::DocumentTypeV0Getters;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `dpp::data_contract::document_type::methods::DocumentTypeV0Methods`:
packages/rs-drive/src/drive/document/mod.rs#L43
warning: unused import: `dpp::data_contract::document_type::methods::DocumentTypeV0Methods`
--> packages/rs-drive/src/drive/document/mod.rs:43:5
|
43 | use dpp::data_contract::document_type::methods::DocumentTypeV0Methods;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `dpp::data_contract::document_type::DocumentTypeRef`:
packages/rs-drive/src/drive/document/mod.rs#L45
warning: unused import: `dpp::data_contract::document_type::DocumentTypeRef`
--> packages/rs-drive/src/drive/document/mod.rs:45:5
|
45 | use dpp::data_contract::document_type::DocumentTypeRef;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
Rust packages (rs-sdk) / Check each feature
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Rust packages (rs-sdk) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Build Docker images (DAPI, dapi, dapi) / Build DAPI image
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/github-script@v6. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/github-script@v6. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
JS code security audit / Run Code QL
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update, github/codeql-action/init@v2, github/codeql-action/analyze@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
JS code security audit / Run Code QL
CodeQL Action v2 will be deprecated on December 5th, 2024. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/
|
|
Rust packages (drive) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Build Docker images (Drive, drive, drive-abci) / Build Drive image
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/github-script@v6. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Rust packages (drive-abci) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Packages functional tests / Run functional tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Test Suite (Test Suite, test:suite, 0, 0) / Run Test Suite
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Test Suite (Test Suite in browser (2), test:browsers, 1, 2) / Run Test Suite in browser (2)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Test Suite (Test Suite in browser (1), test:browsers, 0, 2) / Run Test Suite in browser (1)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|