Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: drop unused includes; use calculate_sign_hash #1767

Merged
merged 1 commit into from
Mar 13, 2024
Merged

refactor: drop unused includes; use calculate_sign_hash #1767

merged 1 commit into from
Mar 13, 2024

Conversation

PastaPastaPasta
Copy link
Member

Issue being fixed or feature implemented

Fix compilation warnings

What was done?

Fix them; @lklimek stated we should indeed use calculate_sign_hash

How Has This Been Tested?

Build locally

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer merged commit 7298616 into v1.0-dev Mar 13, 2024
35 checks passed
@QuantumExplorer QuantumExplorer deleted the refac/trivial-build-warnings branch March 13, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuantumExplorer QuantumExplorer QuantumExplorer approved these changes

@shumkov shumkov Awaiting requested review from shumkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PastaPastaPasta @QuantumExplorer