Backport v18 vijay batch2 #4399

vijaydasmp · 2021-09-08T12:19:15Z

No description provided.

380c843 utils: Convert Windows args to utf-8 string (Chun Kuan Lee) Pull request description: Create a new class `WinCmdLineArgs` when building for Windows. It converts all command line arguments to utf8 string. Tree-SHA512: f098520fd123a8a452bc84a55dc8c0b88f0c475410efe57f2ccc393f86c396eed59ea1575ddc1b920323792e390fdb092061d80cdcd9b682f0ac79a22a22ff82

…a string d4d70ed Fix listreceivedbyaddress not taking address as a string (Eric Scrivner) Pull request description: Fixes bitcoin#14173. Add the patch in bitcoin#14173 and include a regression test. Tree-SHA512: 5a9794e0c43e90d18c899841afbaf15eb9129d7d2f6570fccf0a1793697fe170d224c3c3995b1a35c536fac19819042823d9e3bd23b019d0f03434499243d2f5

vijaydasmp · 2021-09-09T16:45:31Z

CI was failing for tests here on https://gitlab.com/dashpay/dash/-/pipelines/367969510 , , and all other builds were passing , after removing the erring commit
now CI has started showing (https://gitlab.com/dashpay/dash/-/pipelines/368090964 ) error for mac build and x86_64_apple-depends which was passing
I am checking it

PastaPastaPasta · 2021-09-09T20:05:13Z

Hey, if you see CI errors (where it says like "system failure" as opposed to "script failure, let Udjin or I know and we can restart those. CI system is sadly flaky atm, we on working on fixing it behind the scenes

vijaydasmp · 2021-09-09T20:19:59Z

Hi, Thanks for responding, I am observing another issue now, the pipeline is running slower than usual

…

On Fri, 10 Sept 2021 at 01:35, PastaPastaPasta ***@***.***> wrote: Hey, if you see CI errors (where it says like "system failure" as opposed to "script failure, let Udjin or I know and we can restart those. CI system is sadly flaky atm, we on working on fixing it behind the scenes — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4399 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR5IIRILVX4D3BHO4VZZ6DUBEHQHANCNFSM5DUTBQGQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- ~Vijay There are no such things as strangers, only friends we haven't met yet

github-actions · 2021-09-09T20:32:44Z

This pull request has conflicts, please rebase.

vijaydasmp · 2021-09-09T20:33:47Z

I was struggling with CI and spent hours understanding it, For the current changeset (PR) The Pipeline has passed once here https://gitlab.com/dashpay/dash/-/pipelines/368090964, I had force pushed to drop a commit thats why CI is running again, not sure how the CI will behave now, Since I have had one instance of All green here https://gitlab.com/dashpay/dash/-/pipelines/368090964 with the current changes in the PR, I am opening PR for review

UdjinM6 · 2021-09-09T20:37:23Z

Pls drop 14585 (just merged it via #4403 )

Hi, Thanks for responding, I am observing another issue now, the pipeline is running slower than usual

Yeah, pipelines are going to be slow for some time because we switched to shared runners until we fix issues with the dedicated one.

… help texts at runtime bbbbb3f qa: Add test to ensure node can generate all help texts at runtime (MarcoFalke) Pull request description: This might increase coverage, but more importantly this checks that the node doesn't crash when generating the help. (Right now the help is a static string, but in the future it might be generated at runtime) Tree-SHA512: 0226e7c65f8a1a6fdc96c07dcf491d90559bc2355c92e9da9b1f174b09733fc349269e71da6d792f954de563a1e57c848471813eabae1a40b849a0d989520a0d

3fb09b9 Warn unrecognized sections in the config file (Akio Nakamura) Pull request description: This PR intends to resolve bitcoin#14702. In the config file, sections are specified by square bracket pair "[]"$, or included in the option name itself which separated by a period"(.)". Typicaly, [testnet] is not a correct section name and specified options in that section are ignored but user cannot recognize what is happen. So, add some log-warning messages if unrecognized section names are present in the config file after checking section only args. note: Currentry, followings are out of scope of this PR. 1) Empty section name or option name can describe. e.g. [] , .a=b, =c 2) Multiple period characters can exist in the section name and option name. e.g. [c.d.e], [..], f.g.h.i=j, ..=k Tree-SHA512: 2cea02a0525feb40320613989a75cd7b7b1bd12158d5e6f3174ca77e6a25bb84425dd8812f62483df9fc482045c7b5402d69bc714430518b1847d055a2dc304b

vijaydasmp · 2021-09-09T20:55:47Z

Hello, @UdjinM6 dropped 14585, Requesting to review my remaining changes, the pipeline has triggered again, The changeset had passed CI once here https://gitlab.com/dashpay/dash/-/pipelines/368090964, dropping a commit should not be an issue with CI.

UdjinM6

utACK

PastaPastaPasta · 2021-09-09T22:50:46Z

test/functional/test_framework/test_node.py

@@ -375,7 +375,7 @@ def test_success(cmd):
                stderr=subprocess.DEVNULL, stdout=subprocess.DEVNULL) == 0

        if not sys.platform.startswith('linux'):
-            self.log.warning("Can't profile with perf; only availabe on Linux platforms")
+            self.log.warning("Can't profile with perf; only available on Linux platforms")


How is aa94f98 relevant to this PR?

Really also 40ba7d5

Hello @PastaPastaPasta, I have dropped those commits now,

I added aa94f98 change because I saw CI failing once with the below error, I was trying to make CI happy, It was just a warning, but yesterday CI behavior was very flaky

^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/lint-spelling.ignore-words.txt Uploading artifacts for failed job 00:01 Uploading artifacts... WARNING: /builds/dashpay/dash/build-ci: no matching files ERROR: No files to upload

40ba7d5 This change is my error in understanding, I thought correcting obsolete filename would be a good thing to do, (how should we approach these ?, Shall we open a separate PR or create an issue to track it )

Yes, creating a separate PR would be preferable

I have to agree, unrelated patches should be dropped

4674610 Log env path in BerkeleyEnvironment::Flush (João Barbosa) Pull request description: With `bitcoind -regtest -wallet=w1 -wallet=w2 -debug`, before: ``` BerkeleyEnvironment::Flush: Flush(true) BerkeleyEnvironment::Flush: Flushing wallet.dat (refcount = 0)... BerkeleyEnvironment::Flush: wallet.dat checkpoint BerkeleyEnvironment::Flush: wallet.dat detach BerkeleyEnvironment::Flush: wallet.dat closed BerkeleyEnvironment::Flush: Flush(true) took 23ms BerkeleyEnvironment::Flush: Flush(true) BerkeleyEnvironment::Flush: Flushing wallet.dat (refcount = 0)... BerkeleyEnvironment::Flush: wallet.dat checkpoint BerkeleyEnvironment::Flush: wallet.dat detach BerkeleyEnvironment::Flush: wallet.dat closed BerkeleyEnvironment::Flush: Flush(true) took 19ms ``` After: ``` BerkeleyEnvironment::Flush: [/Users/joao/Library/Application Support/Bitcoin/regtest/wallets/w1] Flush(true) BerkeleyEnvironment::Flush: Flushing wallet.dat (refcount = 0)... BerkeleyEnvironment::Flush: wallet.dat checkpoint BerkeleyEnvironment::Flush: wallet.dat detach BerkeleyEnvironment::Flush: wallet.dat closed BerkeleyEnvironment::Flush: Flush(true) took 23ms BerkeleyEnvironment::Flush: [/Users/joao/Library/Application Support/Bitcoin/regtest/wallets/w2] Flush(true) BerkeleyEnvironment::Flush: Flushing wallet.dat (refcount = 0)... BerkeleyEnvironment::Flush: wallet.dat checkpoint BerkeleyEnvironment::Flush: wallet.dat detach BerkeleyEnvironment::Flush: wallet.dat closed BerkeleyEnvironment::Flush: Flush(true) took 19ms ``` Tree-SHA512: f90b413cca5d2527324a264ce371dc8baba69f5b541f7d7f6238a8dd79398cbd3c67c0d7a8a0b69aec6c44d77ba26a079c2241427e3669ed22c7da0e4d60039e

vijaydasmp · 2021-09-10T02:10:51Z

Hello, @PastaPastaPasta @UdjinM6 dropped those 2 commits,

UdjinM6

utACK

PastaPastaPasta

utACK for merging via merge commit

cc3b528 gui: remove OpenSSL PRNG seeding (Windows, Qt only) (fanquake) Pull request description: This removes the code introduced in [dashpay#4399](bitcoin#4399) that attempts to add additional entroy to the OpenSSL PRNG using `RAND_event()`. This is specific to bitcoin-qt running on Windows. ``` RAND_event() collects the entropy from Windows events such as mouse movements and other user interaction. It should be called with the iMsg, wParam and lParam arguments of all messages sent to the window procedure. It will estimate the entropy contained in the event message (if any), and add it to the PRNG. The program can then process the messages as usual. ``` Besides BIP70, this is the last place we are directly using OpenSSL in the GUI code. All other OpenSSL usage is in [random.cpp](https://github.com/bitcoin/bitcoin/blob/master/src/random.cpp). Note that we are still also still doing other Windows specific gathering using [RandAddSeedPerfmon](https://github.com/bitcoin/bitcoin/blob/master/src/random.cpp#L268) and [RAND_screen()](https://github.com/bitcoin/bitcoin/blob/master/src/random.cpp#L600) on top of the other generation we do. Also note that if RAND_event returns `0` here (PRNG has **NOT** been seeded with enough data), we're just logging a single message and continuing, which also seems less than ideal. ACKs for top commit: laanwj: ACK cc3b528 MarcoFalke: unsigned ACK cc3b528 theuni: ACK cc3b528. Tree-SHA512: 0bb18779cf37f6670e3e5ac6a6a38e5f95199491b2684f9e56391c76f030fe1621d6df064239c2a398f228129fdf3f2220fc8cd15b2b92ecf2ea6d98a79b2175

vijaydasmp force-pushed the backport_v18_vijay_batch2 branch 2 times, most recently from 4f03755 to 1ee9c68 Compare September 8, 2021 18:34

vijaydasmp force-pushed the backport_v18_vijay_batch2 branch 5 times, most recently from dfcdec9 to 1346de7 Compare September 9, 2021 13:42

vijaydasmp force-pushed the backport_v18_vijay_batch2 branch from 1346de7 to ad02399 Compare September 9, 2021 14:14

vijaydasmp force-pushed the backport_v18_vijay_batch2 branch from 7a656e1 to 0e5b64c Compare September 9, 2021 20:27

github-actions bot added the needs rebase label Sep 9, 2021

laanwj added 2 commits September 10, 2021 02:19

vijaydasmp force-pushed the backport_v18_vijay_batch2 branch from 0e5b64c to 7fd68ac Compare September 9, 2021 20:49

github-actions bot removed the needs rebase label Sep 9, 2021

vijaydasmp marked this pull request as ready for review September 9, 2021 20:56

UdjinM6 added this to the 18 milestone Sep 9, 2021

UdjinM6 previously approved these changes Sep 9, 2021

View reviewed changes

PastaPastaPasta requested changes Sep 9, 2021

View reviewed changes

vijaydasmp force-pushed the backport_v18_vijay_batch2 branch from 7fd68ac to 158b03e Compare September 10, 2021 02:07

vijaydasmp requested a review from PastaPastaPasta September 10, 2021 06:41

UdjinM6 approved these changes Sep 10, 2021

View reviewed changes

PastaPastaPasta approved these changes Sep 10, 2021

View reviewed changes

PastaPastaPasta merged commit fe03773 into dashpay:develop Sep 10, 2021

vijaydasmp deleted the backport_v18_vijay_batch2 branch December 29, 2021 01:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport v18 vijay batch2 #4399

Backport v18 vijay batch2 #4399

vijaydasmp commented Sep 8, 2021

vijaydasmp commented Sep 9, 2021 •

edited

Loading

PastaPastaPasta commented Sep 9, 2021

vijaydasmp commented Sep 9, 2021 via email

github-actions bot commented Sep 9, 2021

vijaydasmp commented Sep 9, 2021

UdjinM6 commented Sep 9, 2021

vijaydasmp commented Sep 9, 2021

UdjinM6 left a comment

PastaPastaPasta Sep 9, 2021 •

edited

Loading

vijaydasmp Sep 10, 2021

PastaPastaPasta Sep 10, 2021

vijaydasmp commented Sep 10, 2021

UdjinM6 left a comment

PastaPastaPasta left a comment

Backport v18 vijay batch2 #4399

Backport v18 vijay batch2 #4399

Conversation

vijaydasmp commented Sep 8, 2021

vijaydasmp commented Sep 9, 2021 • edited Loading

PastaPastaPasta commented Sep 9, 2021

vijaydasmp commented Sep 9, 2021 via email

github-actions bot commented Sep 9, 2021

vijaydasmp commented Sep 9, 2021

UdjinM6 commented Sep 9, 2021

vijaydasmp commented Sep 9, 2021

UdjinM6 left a comment

Choose a reason for hiding this comment

PastaPastaPasta Sep 9, 2021 • edited Loading

Choose a reason for hiding this comment

vijaydasmp Sep 10, 2021

Choose a reason for hiding this comment

PastaPastaPasta Sep 10, 2021

Choose a reason for hiding this comment

vijaydasmp commented Sep 10, 2021

UdjinM6 left a comment

Choose a reason for hiding this comment

PastaPastaPasta left a comment

Choose a reason for hiding this comment

vijaydasmp commented Sep 9, 2021 •

edited

Loading

PastaPastaPasta Sep 9, 2021 •

edited

Loading