Fix listreceivedbyaddress not taking address as a string #14417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etscrivner
force-pushed
the
fix-rpc-calls-not-taking-valid-strings
branch
from
e57140b to
ccdcd9e
Compare
|
ACK ccdcd9eec9825cc95a75816637960511d67305c1 |
|
utACK ccdcd9e Note that your commit isn't associated with your GitHub account currently, did you use the same email address for both? |
etscrivner
force-pushed
the
fix-rpc-calls-not-taking-valid-strings
branch
from
ccdcd9e to
f80c9ef
Compare
Fixes bitcoin#14173. Add the patch in bitcoin#14173 and include a regression test.
etscrivner
force-pushed
the
fix-rpc-calls-not-taking-valid-strings
branch
from
f80c9ef to
d4d70ed
Compare
|
@meshcollider Thanks! The commit should have the correct email now. |
|
utACK d4d70ed |
maflcko
pushed a commit
that referenced
this pull request
Oct 23, 2018
d4d70ed Fix listreceivedbyaddress not taking address as a string (Eric Scrivner) Pull request description: Fixes #14173. Add the patch in #14173 and include a regression test. Tree-SHA512: 5a9794e0c43e90d18c899841afbaf15eb9129d7d2f6570fccf0a1793697fe170d224c3c3995b1a35c536fac19819042823d9e3bd23b019d0f03434499243d2f5
|
utACK d4d70ed. |
|
Backport me? |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Nov 28, 2018
Fixes bitcoin#14173. Add the patch in bitcoin#14173 and include a regression test. Github-Pull: bitcoin#14417 Rebased-From: d4d70ed
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
May 22, 2020
Summary: d4d70eda33 Fix listreceivedbyaddress not taking address as a string (Eric Scrivner) Pull request description: Fixes #14173. Add the patch in #14173 and include a regression test. Tree-SHA512: 5a9794e0c43e90d18c899841afbaf15eb9129d7d2f6570fccf0a1793697fe170d224c3c3995b1a35c536fac19819042823d9e3bd23b019d0f03434499243d2f5 Backport of Core [[bitcoin/bitcoin#14417 | PR14417]] Test Plan: ninja ninja check ninja check-functional Verify the changes to `wallet_listreceivedby` causes it to fail on master if the changes to `rpc/client.cpp` from this patch are reverted. Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6232
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Jul 21, 2021
…a string d4d70ed Fix listreceivedbyaddress not taking address as a string (Eric Scrivner) Pull request description: Fixes bitcoin#14173. Add the patch in bitcoin#14173 and include a regression test. Tree-SHA512: 5a9794e0c43e90d18c899841afbaf15eb9129d7d2f6570fccf0a1793697fe170d224c3c3995b1a35c536fac19819042823d9e3bd23b019d0f03434499243d2f5
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Aug 16, 2021
…a string d4d70ed Fix listreceivedbyaddress not taking address as a string (Eric Scrivner) Pull request description: Fixes bitcoin#14173. Add the patch in bitcoin#14173 and include a regression test. Tree-SHA512: 5a9794e0c43e90d18c899841afbaf15eb9129d7d2f6570fccf0a1793697fe170d224c3c3995b1a35c536fac19819042823d9e3bd23b019d0f03434499243d2f5
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this pull request
Sep 8, 2021
…a string d4d70ed Fix listreceivedbyaddress not taking address as a string (Eric Scrivner) Pull request description: Fixes bitcoin#14173. Add the patch in bitcoin#14173 and include a regression test. Tree-SHA512: 5a9794e0c43e90d18c899841afbaf15eb9129d7d2f6570fccf0a1793697fe170d224c3c3995b1a35c536fac19819042823d9e3bd23b019d0f03434499243d2f5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14173. Add the patch in #14173 and include a regression test.