Use the same Java/Kotlin versions as the flutter android template #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type-infra
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR).
API leaks
|
| Package | Leaked API symbols |
|---|---|
| ok_http | $Certificate$NullableType $Certificate$Type PublicKey $PublicKey$NullableType $PublicKey$Type $PublicKey $X509Certificate$NullableType $X509Certificate$Type $PrivateKey$NullableType $PrivateKey$Type $PrivateKey |
This check can be disabled by tagging the PR with skip-leaking-check.
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
| Files |
|---|
| pkgs/http/example/main.dart |
| pkgs/http_client_conformance_tests/example/client_test.dart |
| pkgs/http_client_conformance_tests/lib/src/dummy_isolate.dart |
| pkgs/http_parser/test/example_test.dart |
| pkgs/http_profile/lib/http_profile.dart |
| pkgs/web_socket/example/web_socket_example.dart |
| pkgs/web_socket/lib/testing.dart |
| pkgs/web_socket_conformance_tests/example/client_test.dart |
HosseinYousefi
approved these changes
Feb 5, 2025
| @@ -29,8 +29,12 @@ android { | |||
| ndkVersion = flutter.ndkVersion | |||
|
|
|||
| compileOptions { | |||
| sourceCompatibility = JavaVersion.VERSION_21 | |||
| targetCompatibility = JavaVersion.VERSION_21 | |||
| sourceCompatibility = JavaVersion.VERSION_1_8 | |||
There was a problem hiding this comment.
Shouldn't this be also VERSION_11?
There was a problem hiding this comment.
I copied this from the flutter java plugin template without thinking about the values too much. Let me try VERSION_11.
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Feb 10, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. core (https://github.com/dart-lang/core/compare/2458e1a..a896913): a8969137 2025-02-06 Devon Carew normalize the workflow files (dart-lang/core#857) http (https://github.com/dart-lang/http/compare/c7cc4f8..b7cdf61): b7cdf61 2025-02-07 Vladislav Fix Default Encoding for application/json Content-Type in HTTP Responses (dart-lang/http#1422) aadf836 2025-02-05 Brian Quinlan Use the same Java/Kotlin versions as the flutter android template (dart-lang/http#1708) 2e1a9a6 2025-02-05 Brian Quinlan Upgrade to `jni`/`jnigen` 0.14.0 (dart-lang/http#1707) test (https://github.com/dart-lang/test/compare/2ccfc5c..17609bf): 17609bf9 2025-02-07 Kevin Moore [test] allow the latest version of pkg:shelf_web_socket (dart-lang/test#2457) 73d629d2 2025-02-06 Kevin Moore Enable and fix unnecessary_ignore lint (dart-lang/test#2456) Change-Id: Ie9f773289e94f04caeab10fb4902f78443292705 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408861 Commit-Queue: Konstantin Shcheglov <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1704
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.