Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to jni/jnigen 0.14.0 #1707

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

brianquinlan
Copy link
Collaborator

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented Feb 4, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
ok_http Non-Breaking 0.1.0 0.1.1-wip 0.1.1 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
pkgs/ok_http/example/integration_test/certificate_test.dart 💔 Not covered
pkgs/ok_http/lib/src/ok_http_client.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
ok_http $Certificate$NullableType
$Certificate$Type
PublicKey
$PublicKey$NullableType
$PublicKey$Type
$PublicKey
$X509Certificate$NullableType
$X509Certificate$Type
$PrivateKey$NullableType
$PrivateKey$Type
$PrivateKey

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/http/example/main.dart
pkgs/http_client_conformance_tests/example/client_test.dart
pkgs/http_client_conformance_tests/lib/src/dummy_isolate.dart
pkgs/http_parser/test/example_test.dart
pkgs/http_profile/lib/http_profile.dart
pkgs/web_socket/example/web_socket_example.dart
pkgs/web_socket/lib/testing.dart
pkgs/web_socket_conformance_tests/example/client_test.dart

Copy link
Member

@HosseinYousefi HosseinYousefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brianquinlan brianquinlan merged commit 2e1a9a6 into dart-lang:master Feb 5, 2025
32 of 33 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Feb 10, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

core (https://github.com/dart-lang/core/compare/2458e1a..a896913):
  a8969137  2025-02-06  Devon Carew  normalize the workflow files (dart-lang/core#857)

http (https://github.com/dart-lang/http/compare/c7cc4f8..b7cdf61):
  b7cdf61  2025-02-07  Vladislav  Fix Default Encoding for application/json Content-Type in HTTP Responses (dart-lang/http#1422)
  aadf836  2025-02-05  Brian Quinlan  Use the same Java/Kotlin versions as the flutter android template (dart-lang/http#1708)
  2e1a9a6  2025-02-05  Brian Quinlan  Upgrade to `jni`/`jnigen` 0.14.0 (dart-lang/http#1707)

test (https://github.com/dart-lang/test/compare/2ccfc5c..17609bf):
  17609bf9  2025-02-07  Kevin Moore  [test] allow the latest version of pkg:shelf_web_socket (dart-lang/test#2457)
  73d629d2  2025-02-06  Kevin Moore  Enable and fix unnecessary_ignore lint (dart-lang/test#2456)

Change-Id: Ie9f773289e94f04caeab10fb4902f78443292705
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408861
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants