Add lints for v2.0 #72
Conversation
pubspec.yaml
Outdated
|
|
||
| environment: | ||
| sdk: '>=2.12.0 <3.0.0' | ||
| sdk: '>=2.17.0-0 <3.0.0' |
There was a problem hiding this comment.
Need to verify that this is the lower bound that we want.
There was a problem hiding this comment.
Since nobody has raised any concerns about this in the email thread, I am assuming this constraint is good.
There was a problem hiding this comment.
Using a non-stable lower bound is OK. It has the added benefit that we can publish prior to 2.17 stable going out, and pub.dev will show the package as a "pre-stable release" until the exact moment 2.17 stable launches.
But rather than using -0 we should perhaps use the build number for the lowest release that supports all the lints that we're including here?
There was a problem hiding this comment.
I am going to set this to 2.17.0-206.0.dev, which is the lowest version that contains all autofixes for the lints we are enabling.
For reference, the last autofix was added in dart-lang/sdk@0d130c3. This version has not rolled into Flutter yet, but should be in the next few hours.
| @@ -8,13 +8,15 @@ linter: | |||
| - camel_case_extensions | |||
| - camel_case_types | |||
| - curly_braces_in_flow_control_structures | |||
| - depend_on_referenced_packages | |||
There was a problem hiding this comment.
Auto fix for this one is still under discussion, see https://github.com/dart-lang/lints/issues/42.
There was a problem hiding this comment.
We are going to ship this without an autofix.
|
🚀 |
|
I am just waiting on |
See https://github.com/dart-lang/lints/projects/1.
Fixes dart-lang/core#764
Fixes dart-lang/core#749
Fixes dart-lang/core#740
Fixes dart-lang/core#771
Fixes dart-lang/core#761
Fixes dart-lang/core#766
Fixes dart-lang/core#768
Fixes dart-lang/core#767
Fixes https://github.com/dart-lang/lints/issues/70
Fixes dart-lang/core#758