Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding unnecessary_nullable_for_final_variable_declarations #767

Closed
goderbauer opened this issue Jan 10, 2022 · 4 comments · Fixed by dart-archive/lints#72
Closed

Comments

@goderbauer
Copy link
Contributor

Cleaner code, less mental overhead. Enabled in Flutter.

@goderbauer goderbauer changed the title Consider adding unnecessary_nullable_for_final_variable_declarations Consider adding unnecessary_nullable_for_final_variable_declarations Jan 10, 2022
@mit-mit
Copy link
Member

mit-mit commented Jan 11, 2022

Need to fix metadata:

Maturity: experimental
Linter v0.1.118

@mit-mit
Copy link
Member

mit-mit commented Jan 11, 2022

Approved assuming this is only for local variables.

@pq
Copy link
Member

pq commented Jan 11, 2022

Currently it does cover fields and top-level variable declarations in addition to locals.

For fields, would it be sufficient to update it to skip the override case?

/cc @lrhn

@srawlins
Copy link
Member

srawlins commented Mar 1, 2022

This has a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants