Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler-versions.cmake: 2024 edition #663

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

LebedevRI
Copy link
Member

LLVM16 migrated into debian stable.
macOS 12 will become EOL in summer.

Therefore, for the summer dt release,
we can require macOS 13 + XCode 15.2,
which means we'll be able to bump required LLVM version up to 15 or even 16.

@TurboGit @zisoft FYI ^
I'm really looking forward dropping at least the LLVM14 support.

LLVM16 migrated into debian stable.
macOS 12 will become EOL in summer.

Therefore, for the summer dt release,
we can require macOS 13 + XCode 15.2,
which means we'll be able to bump required LLVM version
up to 15 or even 16.
@LebedevRI LebedevRI merged commit b1b4b04 into darktable-org:develop Feb 13, 2024
56 of 57 checks passed
@LebedevRI LebedevRI deleted the compiler-versions branch February 14, 2024 00:04
@zisoft
Copy link

zisoft commented Feb 14, 2024

Yes, that's the plan and I have already made some tests with the macos-13 runner.
Unfortunately, Xcode 15 segfaults on this runner when compiling src/common/iop_profile.c: 15945.
Does not happen with Xcode 14.

Is there something special in iop_profile.c? I have opened this issue in the hope that some compiler experts can have a look.

@LebedevRI
Copy link
Member Author

Yes, that's the plan and I have already made some tests with the macos-13 runner.

Do you think the bump could happen right after the next point release of stable series of dt?
(pending darktable-org/darktable#15945 ?)

@TurboGit
Copy link
Member

@zisoft : There is some DT_CLONE_TARGETS on this unit, but that's not the only one. It a a somewhat large file too 66k but nothing huge. So not sure why iop_profile.c crash the compiler here.

@LebedevRI : Seems like LLVM version 16 in Debian is not in stable but in testing at the moment.

@LebedevRI
Copy link
Member Author

@LebedevRI : Seems like LLVM version 16 in Debian is not in stable but in testing at the moment.

Are you sure you are not mixing up LLVM 17 and LLVM 16?
LLVM17 is in testing and not stable, but LLVM16 did migrate into stable: https://packages.debian.org/bookworm/clang-16

@TurboGit
Copy link
Member

That's strange...

$ apt policy llvm
llvm:
  Installé : (aucun)
  Candidat : 1:16.0-57
 Table de version :
     1:16.0-57 500
        500 http://ftp.debian.org/debian testing/main amd64 Packages
     1:14.0-55.7~deb12u1 500
        500 http://ftp.debian.org/debian stable/main amd64 Packages

So 14 on stable and 16 on testing.

Likewise for clang package:

$ apt policy clang
[sudo] Mot de passe de pascal : 
clang:
  Installé : (aucun)
  Candidat : 1:16.0-57
 Table de version :
     1:16.0-57 500
        500 http://ftp.debian.org/debian testing/main amd64 Packages
     1:14.0-55.7~deb12u1 500
        500 http://ftp.debian.org/debian stable/main amd64 Packages

Wait... That's because this is only the default install, but one can install more recent versions:

On testing:

$ apt show clang-17
Package: clang-17
Version: 1:17.0.6-5
Priority: optional
Section: devel
Source: llvm-toolchain-17
...

So, indeed no problem to bump CLang version.

@LebedevRI
Copy link
Member Author

I'm not sure what you are looking at, i literally have a LLVM16 @ bookworm CI entry: https://github.com/darktable-org/rawspeed/actions/runs/7895101031/job/21546912094

As i've said, rawspeed will only be able to bump to LLVM15 (google/oss-fuzz#9989 :/),
but dt should be able to bump all the way to LLVM16.

@zisoft
Copy link

zisoft commented Feb 14, 2024

Do you think the bump could happen right after the next point release of stable series of dt?

With darktable.org/darktable#15945 fixed we can bump to

{ os: macos-13, xcode: "15.2", deployment: 13.5 }

@LebedevRI
Copy link
Member Author

Awesome! Let's get point release out of the door soon, and do that!

zisoft referenced this pull request in darktable-org/darktable Jun 19, 2024
Dt 4.8 drops support for macOS <13.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants