Moving middleware out of repo to dapr/samples #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Yuknewicz <[email protected]>
paulyuk
force-pushed
the
paulyuk/movemiddleware
branch
from
7af25de to
a098291
Compare
|
Related to: dapr/samples#94 |
7 tasks
|
You also have to edit the https://github.com/dapr/quickstarts readme file, to remove the middleware from the list and the page |
|
@msfussell good catch, i did this from docs but not readme itself. thank you. |
Signed-off-by: Paul Yuknewicz <[email protected]>
paulyuk
force-pushed
the
paulyuk/movemiddleware
branch
from
442fa58 to
4473118
Compare
Signed-off-by: Paul Yuknewicz <[email protected]>
|
All tests pass after re-run. @msfussell |
7 tasks
4 tasks
Arashrohani
pushed a commit
to Arashrohani/quickstarts
that referenced
this pull request
Feb 16, 2022
* Moving middleware out of repo to dapr/samples Signed-off-by: Paul Yuknewicz <[email protected]> * removing middleware from readme Signed-off-by: Paul Yuknewicz <[email protected]> * Updated test to remove middleware sample folder Signed-off-by: Paul Yuknewicz <[email protected]> Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Arash Rohani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving middleware sample out of this repo and into the dapr/samples repo
Issue reference
Fixes #512
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: