[DAPHNE-#554] Use hwloc to query CPU topology #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests fail because of the missing library in the github action docker image. Is this the only reason why this PR is in draft state? |
|
I've only run this on a single-node x86 server. I'll do some tests on the NUMA ARM server we have in the lab, and if everything works out, I'll mark it ready. The topology discovery could be improved upon but we can merge this PR and open a new issue about expanding the hwloc / topology discovery support. |
|
It seems to also work on our dual-socket ARM server, so I think it can be merged. I've also created #569 to track any progress with further integrating hwloc into the runtime / vectorized engine. |
|
LGTM - Thx @psomas, finally merged :) |
GuilloteauQ
pushed a commit
to GuilloteauQ/daphne
that referenced
this pull request
Jan 22, 2024
Merged
philipportner
pushed a commit
that referenced
this pull request
Jan 23, 2024
CPestka
pushed a commit
to CPestka/daphne
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #554