Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-portable cpu query in get_topology() #554

Closed
corepointer opened this issue Jun 28, 2023 · 0 comments · Fixed by #563
Closed

non-portable cpu query in get_topology() #554

corepointer opened this issue Jun 28, 2023 · 0 comments · Fixed by #563
Assignees
@psomas
Labels
bug A mistake in the code.

Comments

@corepointer
Copy link
Collaborator

The method get_topology(...) in MTWrapper.h is parsing the output of /proc/cpuinfo which seems to be tailored to x86-64 processors as this fails on ARM.

A proper fix for this was already discussed to be the use of the hwloc library [1]. Until that solution is in place there will be a quick-fix that makes ARM run (filling the vectors to be filled by that method with generic IDs).

[1] https://www.open-mpi.org/projects/hwloc/
@corepointer corepointer added the bug A mistake in the code. label Jun 28, 2023
corepointer added a commit that referenced this issue Jun 28, 2023
@corepointer
[BUGFIX] Workaround for get_topology() on ARM
505e2a3 
Until DAPHNE-#554 is implemented, this serves as a work around to get the vectorized engine running on ARM and to pass test cases.
@psomas psomas self-assigned this Jul 3, 2023
This was referenced Jul 4, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psomas psomas

Labels
bug A mistake in the code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DAPHNE-#554] Use hwloc to query CPU topology psomas/daphne
2 participants
@psomas @corepointer