Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-623 ci: Simplify the pull request template #15969

Merged
merged 8 commits into from
Feb 25, 2025
Merged

DAOS-623 ci: Simplify the pull request template #15969

merged 8 commits into from
Feb 25, 2025

Conversation

jolivier23
Copy link
Contributor

Document just the essentials

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@jolivier23
DAOS-623 ci: Simplify the pull request template
da5aa7a 
Document just the essentials

Signed-off-by: Jeff Olivier <[email protected]>
@jolivier23 jolivier23 requested a review from a team as a code owner February 24, 2025 22:21
@jolivier23
Skip-build: true
ebdfa74 
Doc-only: true

Signed-off-by: Jeff Olivier <[email protected]>
@jolivier23
minor typo
29eb82c 
Doc-only: true
Skip-build: true

Signed-off-by: Jeff Olivier <[email protected]>
@jolivier23
Fix a few typos
a4a9e26 
Skip-build: true
Doc-only: true

Signed-off-by: Jeff Olivier <[email protected]>
0xE0F
0xE0F previously approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@0xE0F 0xE0F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@github-actions GitHub Actions
Copy link

Ticket title is 'Generic ticket for minor code cleanup and improvement'
Status is 'Resolved'
Labels: 'request_for_2.6.3'
https://daosio.atlassian.net/browse/DAOS-623

mchaarawi
mchaarawi reviewed Feb 24, 2025
View reviewed changes
.github/pull_request_template.md Outdated
* [ ] Fix the commit message upon landing. Check the standard [here](https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments). Edit it to create a single commit. If necessary, ask submitter for a new summary.
* [ ] Commit message follows the [guidelines](https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments).
* [ ] Appropriate [Features or Test-tag](https://daosio.atlassian.net/wiki/spaces/DC/pages/10984259629/Test+Tags) pragmas were used.
* [ ] At least two code positive reviews including at least one review from any code owners tagged.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • should this say that at least one code owner from each category approves (for large PRs that modify more than 1 area)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jolivier23
address review
09c5bd3 
Skip-build: true
Doc-only: true

Signed-off-by: Jeff Olivier <[email protected]>
@jolivier23
Skip-build: true
a6edf7b 
Doc-only: true

Signed-off-by: Jeff Olivier <[email protected]>
@jolivier23
Copy link
Contributor Author

jolivier23 commented Feb 25, 2025 •
edited
Loading

https://github.com/daos-stack/daos/blob/b0a5781b1a046c05a4f661335011e034c13b9a68/.github/pull_request_template.md

@jolivier23
Add testing is complete
b0a5781 
Skip-build: true
Doc-only: true

Signed-off-by: Jeff Olivier <[email protected]>
@jolivier23 @daltonbohning
Update .github/pull_request_template.md
40d5469 
Co-authored-by: Dalton Bohning <[email protected]>
Signed-off-by: Jeff Olivier <[email protected]>
@jolivier23 jolivier23 merged commit 470603b into master Feb 25, 2025
39 checks passed
@jolivier23 jolivier23 deleted the jvolivie/pr-template branch February 25, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning approved these changes

@phender phender phender approved these changes

@cdavis28 cdavis28 Awaiting requested review from cdavis28

@mchaarawi mchaarawi Awaiting requested review from mchaarawi

@0xE0F 0xE0F Awaiting requested review from 0xE0F

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jolivier23 @0xE0F @mchaarawi @daltonbohning @phender